fsd#2976
Closed
ukreddy-erwin wants to merge 55 commits into
Closed
fsd#2976ukreddy-erwin wants to merge 55 commits into
ukreddy-erwin wants to merge 55 commits into
Conversation
* Added description for 2 'committee' tags * Fixing slashes direction
) * modify Start-PSPester to accept -Quiet to eliminate Pester output also modify travis.ps1 to include -Quiet for Pester args to reduce stdout log size which should hopefully allow daily builds to run without being cancelled due to too much output * Add error detail information as part of Test-PSPesterResults Test-PSPesterResults will now also emit information about the errors found during a test run rather than just the number of failed tests. Created a new errorlog function so the output of errors will be red.
When the build fails there are no $nugetArtifacts, so AddRange fails
Our private implementation of FailFast was likely introduced when each individual application needed it's own code to get Watson reports. The CLR takes care of this for us now, so we don't need our implementation. Our method CheckForSevereException was also introduced in the early days of the CLR - the exceptions it was checking for aren't actually raised the CLR anymore, they just FailFast. I removed them as there is a tiny bit of overhead (in code size) and also in the generated code, e.g. dynamic sites called the method.
A non-terminating error is thrown when the namespace does not exist by Get-CimInstance. The namespace is not present on OS versions below Windows 10. It is not caught in the try-catch unless ErrorAction Stop is added.
…n non-text responses (#2811) * Wrapping a call to Registry with a check for Platform.IsWindows
* RFC 0010 SSH remoting cmdlet updates. * Tweaks to SSH remoting cmdlets * SSHTransport parameter is now optional instead of mandatory. Aded fix for CoreCLR entry point when hosted in SSH as a subsystem. * Added tests * Code review feedback * Code review comment changes * Making SSHTransport switch parameter mandatory because otherwise existing Invoke-Command parameter set * The new SSH parameter set was causing legacy positional based parameters to no longer work. This fix separates the SSH parameter sets from the existing WinRM parameter sets. * Fixed region name spelling error.
Using LanguagePrimitives.ConvertTo (to emulate what would happen if the property were a regular .Net property typed as string), we now convert the value assigned to an XML property to string.
…P on Linux and OSX
* Assign $ProgressPreference = "SilentlyContinue" to reduce output size Travis is still complaining that the log file is too big, eliminating progress is another step to reducing output. It's also not needed for our CI environment. * Removed white space at end of lines * fix misplacement of progress preference setting also fix up trailing whitespace
Literal translation of New-TemporaryFile function to a C# cmdlet, other than moving logic from Begin to End.
* Rebase onto .NET Core 1.1 Modify `Build.psm1` and `project.json` files to use .NET Core 1.1. .NET Core 1.1 ships with an older dotnet/cli than has currently been used, so we revert to use case-sensitive directory names for dependencies. .NET Core 1.1 is a pre-requisite for supporting Fedora 24. * PSReadLine: Bump major version of PSReadline to 6.0.0-* * Microsoft.PowerShell.Commands.Utility: Bump major version of Microsoft.CodeAnalysis.Csharp * Microsoft.PowerShell.SDK: Revert attempt to import netcoreapp1.1 instead of dnxcore * build.psm1: Restore ability to specify version of dotnet-install.sh
* Fix OpenCover.console.exe parameter ordering issue. The targetargs parameter needs to be at the end, otherwise everything after that is considered as part of targetargs. * Addressed code review comments * Removed unnecessary file
This file contained many occurrences of U+F0A7, a character from the designated Private Use Area, so its meaning is not defined and fonts can assign any symbol to that character. Since the person who originally wrote this file works at Microsoft, it seems reasonable to assume that he was using the Wingdings font, which has a bullet character at U+F0A7. Thus, replacing these characters with the proper Unicode bullet (U+2022) seems the right way to fix this.
…ion. (#2837) When a PS class is defined in a module and the module gets reloaded, the class would still use the SessionState from the old module for execution, and thus it doesn't reflect changes to the module state during the reload. This fix is to make sure we always use the current EngineSessionState for PS class execution.
* Refactor 'FindMatchingHandler' to get rid of recursion Search state can be saved and used throughout the searching process without the recursion. * Rank the exception types based on how specific they are * Refactor code to find handler based on the rank of given handlers
Code changes per PR code review - 3
… fixes (#2757) * Adding windows server names to the windows packages + Misc formatting fix Misc fixes are: - Added Get-PackageSemanticVersion function - Added New-ZipPackage function to separate the Zip packaging code - Removed ending ';' in hashtable syntax since entries are on new lines - Standardized the variable name from $Source to $PackageSourcePath for various packaging functions - Removed 'return' in the function end to output the variable value - Added -verbose to Write-Verbose to show the paths of various packages * update * Adding windows server names to the windows packages + Misc formatting fix Misc fixes are: - Added Get-PackageSemanticVersion function - Added New-ZipPackage function to separate the Zip packaging code - Removed ending ';' in hashtable syntax since entries are on new lines - Standardized the variable name from $Source to $PackageSourcePath for various packaging functions - Removed 'return' in the function end to output the variable value - Added -verbose to Write-Verbose to show the paths of various packages * update * Addressing review feedback * Removed the $PackageVersion variable per review feedback * Error message fix
#2862) * This change fixes the Invoke-RestMethod cmdlet behavior if the input is neither xml nor json. * test description * fixed the failed tests * removed some duplication * refactoring: eliminated some double castings * added JsonObject unit tests; enhanced JSON deserialization exception message * refactored JsonObject.Tests.ps1 * entitled test cases * formatting
Changed the package name from the standard Powershell_6.0.0-xx-gxxxxxxx to CodeCoverage.zip so that it is easier to download the latest package from the AppVeyor permalink for last successful build.
V6.0.0 alpha.14 doc changes
…lGet module on Non-Windows platforms. (#2897)
Add the code coverage badge to the nightly build table. The code coverage data is collected on an Azure instance and pushed to Coveralls.io
Type completion would behave strangely when there were multiple aliases for a given type (currently only possible with type accelerators). The fix is to only select the accelerator that matches what the user typed. Closes #2295
This change is a breaking change but falls into compat bucket #3 - unlikely grey area.
The tokenizer did multiple scans the script line to get tokens. Before the fix the tokenizer on the first pass examined that string as double-quoted (Expandable) string not as here string, figured the average double quotation mark as a closing and then starting with the single quotation mark continued processing the line as single-quoted string which had no closing single quotation mark. The fix is to stop the first scan pass after getting '=' (assume assignment-expression '$a=' for next pass).
* build: Update build.sh to run fully manual build * add ubuntu-16.10-x64 to the list of architectures to build for.w
Modify output of Get-Process to display PM and WS in MB instead of KB. Also change precision of CPU time to 2.
* All test reported as skipped if not applicable to the platform
Fixed files:
powershell\Modules\Microsoft.PowerShell.Management\Clear-EventLog.Tests.ps1:1:if
($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Get-ComputerInfo.Tests.ps1:1325:
return
powershell\Modules\Microsoft.PowerShell.Management\Get-EventLog.Tests.ps1:1:if
($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\New-EventLog.Tests.ps1:1:if
($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Registry.Tests.ps1:7:
if ($IsWindows -eq $false) {
powershell\Modules\Microsoft.PowerShell.Management\Registry.Tests.ps1:167:
if ($IsWindows -eq $false) {
powershell\Modules\Microsoft.PowerShell.Management\Remove-EventLog.Tests.ps1:1:if
($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\TimeZone.Tests.ps1:17:if
($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1:6:if
($IsWindows) {
powershell\engine\Help\HelpSystem.Tests.ps1:112: if ($IsWindows)
* Fix test after code review
* Move skiping to common 'try'
This script downloads the latest nightly build package and executes the tests on it. It also downloads all necessary tools and then uploads the results to Coveralls.io. The badge for coverage is posted on README.md
…on IoT. (#2952) * Adding PlatformNotSupportedException to *-Counter cmdlets for IoT as pdh.dll is not available. * Adding tests to validate PlatformNotSupportedException for the Counter cmdlets on IoT.
Previously contained Alpha.12 values - Need to find some way of automating this. #2960
* Fix test where Export-Alias * fails when only single file exists The test expects multiple files to be present at the location. We explicitly create multiple files now under $TestDrive and use that the location for Export-Alias Also, so test structure changes. * Address code review comments
* Initial support for Fedora 24 This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH. * Update Dockerfile Fix typos
|
Hi @ukreddy-erwin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Author
|
zcxc |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdf