Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Build] Remove PSGetModuleInfo.xml from PowerShellGet module on Non-Windows platforms#2897

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
bmanikm:bmanikm-remove-psgetmoduleinfo-file-non-windowsbmanikm/PowerShell:bmanikm-remove-psgetmoduleinfo-file-non-windowsCopy head branch name to clipboard
Dec 17, 2016
Merged

[Build] Remove PSGetModuleInfo.xml from PowerShellGet module on Non-Windows platforms#2897
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
bmanikm:bmanikm-remove-psgetmoduleinfo-file-non-windowsbmanikm/PowerShell:bmanikm-remove-psgetmoduleinfo-file-non-windowsCopy head branch name to clipboard

Conversation

@bmanikm

@bmanikm bmanikm commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

Updated the logic to remove PSGetModuleInfo.xml from PowerShellGet module on Non-Windows platforms.

@lzybkr

lzybkr commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

Does it really need to be that complicated to delete a single file? Isn't it in a well-known location? Should it just be something like:

Remove-Item -Path $Destination\$(_.Name)\*\PSGetModuleInfo.xml -Force

@bmanikm bmanikm force-pushed the bmanikm-remove-psgetmoduleinfo-file-non-windows branch from c686cbb to 3aa73db Compare December 17, 2016 01:03
@bmanikm

bmanikm commented Dec 17, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @lzybkr ! I have incorporated the suggested change.

@PowerShellTeam PowerShellTeam added the Review - Needed The PR is being reviewed label Dec 17, 2016
@daxian-dbw daxian-dbw merged commit 3938cdb into PowerShell:master Dec 17, 2016
@bmanikm bmanikm deleted the bmanikm-remove-psgetmoduleinfo-file-non-windows branch December 17, 2016 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.