Initial Support for Fedora 24#2738
Initial Support for Fedora 24#2738mirichmo merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom randomvariable:Fedora24Copy head branch name to clipboard
Conversation
|
Hi @randomvariable, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Not added Fedora to https://github.com/PowerShell/PowerShell/blob/master/docker/launch.sh#L32 as it presumably wont work without an initial image on the Docker Hub? |
This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.
|
Hi @randomvariable, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
Was lazily trying to get Travis to rerun tests as it hung last time ^ |
|
Tests passed. This is ready for review. |
Fix typos
|
afaict, lgtm |
|
@randomvariable for the |
andyleejordan
left a comment
There was a problem hiding this comment.
As far as I can tell, this hits all the marks except updated documentation. With Fedora 24 supported, the readme etc. should probably be updated to reflect that, but I approve this.
|
@randomvariable I imagine you did a test past of the build, and tried out the generated package too? |
|
It's my default shell right now... |
|
I reverted this PR because it caused a build break on Ubuntu. Details are in #2970. |
* Initial support for Fedora 24 This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH. * Update Dockerfile Fix typos
* Initial support for Fedora 24 This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH. * Update Dockerfile Fix typos
* Initial support for Fedora 24 This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH. * Update Dockerfile Fix typos
Add support for Fedora 24.
This PR adds initial support for the Fedora distribution, starting with Fedora 24.
Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of
libicu50via LD_LIBRARY_PATH.Closes #1882