Support Fedora 24 (redux)#2982
Support Fedora 24 (redux)#2982
Conversation
There was a problem hiding this comment.
Please add a reference to the discussion on the GitHub for the context
There was a problem hiding this comment.
This is owned by @randomvariable: can you open a PR on top of this to fix up the comments? (Or do it with the documentation additions.)
There was a problem hiding this comment.
That should probably go away after the next release, correct?
There was a problem hiding this comment.
Hm I'm not sure why my name is on this Dockerfile as maintainer, it should be @randomvariable's probably.
There was a problem hiding this comment.
The comment implies that this applies only to Fedora 24. Should we add an additional condition to the IF statement?
if ($IsFedora -AND Test-Path ENV:LD_LIBRARY_PATH) {
|
And thanks for addressing the issue @andschwa |
* Initial support for Fedora 24 This commit adds initial support for the Fedora distribution, starting with Fedora 24. Whereever possible, build tooling for CentOS has been reused. Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH. * Update Dockerfile Fix typos
`$rpm_dist` used to be unconditionally defined, but the changes to support Fedora made it defined only on RedHat family platforms, so the variable was undefined on Ubuntu but the flag still added to fpm's arguments, causing a build error. Now we only add the flag and its argument when it's relevant.
13f01a6 to
8796de2
Compare
|
I'm not seeing any activity from @randomvariable, so I updated his changes per the comments. |
8796de2 to
8644d1e
Compare
|
I've got an in-person merge approval from @lzybkr, I'll get this finished. |
This reapplies #2738 with a bug fix for #2970.
@paulcallen you'll need to rebase your work-in-progress again if this gets in first.
I tested package creation and installation on the Ubuntu 16.04 Docker image:
and the CentOS 7 image: