Code coverage automation script by adityapatwardhan · Pull Request #2918 · PowerShell/PowerShell

adityapatwardhan · Dec 21, 2016

This script downloads the latest nightly build package and executes the
tests on it. It also downloads all necessary tools and then uploads the
results to Coveralls.io. The badge for coverage is posted on README.md

This script downloads the latest nightly build package and executes the tests on it. It also downloads all necessary tools and then uploads the results to Coveralls.io. The badge for coverage is posted on README.md

lzybkr · Dec 21, 2016

+$openCoverZip = 'https://ci.appveyor.com/api/projects/PowerShell/powershell-f975h/artifacts/OpenCover.zip'
+
+
+New-Item "$PSScriptRoot\logs.txt"  -Force


You might consider putting the log in some more typical output directory, or at least adding the file you create to .gitignore.

lzybkr · Dec 22, 2016

+
+try
+{
+    "Starting downloads." | Tee-Object -FilePath "$PSScriptRoot\logs.txt" -Append


Maybe you should add a log helper function.

lzybkr · Dec 22, 2016

+
+    "Test run done.!!" | Tee-Object -FilePath "$PSScriptRoot\logs.txt" -Append
+
+    $powershellVersionString = (Get-Content "$psBinPath\publish\powershell.version")


I expect this file to go away at some point - it would be better to get the string from PowerShell itself, e.g.

$powershellVersionString = & $psBinPath\publish\powershell.exe -noprofile -command '$PSVersionTable.GitCommitId'

Addressed CR comments about log file location, logging function and usage of powershell.version file. Also added a README.md file explaining the process.

adityapatwardhan · Dec 22, 2016

@lzybkr Addressed CR comments

Fix the bug in invoking $PSversionTable. Added -force to expand-archive cmdlets.

JamesWTruher · Jan 3, 2017

+        $Path = "$env:Temp\CodeCoverageRunLogs.txt"
+    )
+
+    $message = "$([Datetime]::Now.ToShortDateString()) - $([datetime]::Now.ToShortTimeString()) : $message"


$message = "$([Datetime]::Now.ToShortDateString()) - $([datetime]::Now.ToShortTimeString()) : $message" [](start = 4, length = 103)

this can also be done as:
"{0:d} - {0:t} : {1}" -f ([datetime]::now),$message
or even:
"{0} : {1}" -f ([datetime]::now),$message
although this last changes the string a bit #Resolved

Fixed.

In reply to: 94473993 [](ancestors = 94473993)

JamesWTruher · Jan 3, 2017

+    else
+    {
+        Add-Content -Path $Path -Value $Message -PassThru
+    }


would just add-content -force do the trick (add-content will create the file if it doesn't exist) #Resolved

Fixed.

In reply to: 94474364 [](ancestors = 94474364)

JamesWTruher · Jan 3, 2017

+
+    Invoke-WebRequest -uri $codeCoverageZip -outfile "$outputBaseFolder\PSCodeCoverage.zip"
+    Invoke-WebRequest $testContentZip -outfile "$outputBaseFolder\tests.zip"
+    Invoke-WebRequest $openCoverZip -outfile "$outputBaseFolder\OpenCover.zip"


for consistency - add -uri to these lines too? #Resolved

Fixed.

In reply to: 94474590 [](ancestors = 94474590)

JamesWTruher · Jan 3, 2017

+Write-LogPassThru -Message "openCoverZip: $openCoverZip"
+
+$outputBaseFolder = "$env:Temp\CC"
+$null = New-Item -ItemType Directory -Path $outputBaseFolder -Force


this path may already exist with contents. Would it be a good thing to delete the directory (recursively) if it exists before starting?
ah - i see, it's removed as part of finally, perhaps it's not needed #WontFix

JamesWTruher · Jan 3, 2017

+    $coverallsPath = "$outputBaseFolder\coveralls"
+
+    ## Saving the nupkg as zip so we can expand it.
+    Invoke-WebRequest $coverallsToolsUrl -outfile "$outputBaseFolder\coveralls.zip"


$coverallsToolsUrl [](start = 22, length = 18)

-uri? #Resolved

fixed

In reply to: 94474891 [](ancestors = 94474891)

JamesWTruher · Jan 3, 2017

+    Write-LogPassThru -Message $commitId
+
+    $coverallsPath = "$outputBaseFolder\coveralls"
+    $coverallsToken = 'SaRLabTUDNqaO2JT9uuYcR78a7kia044D'


secrets should probably be provided rather than embedded #Resolved

Fixed.

In reply to: 94475097 [](ancestors = 94475097)

JamesWTruher · Jan 3, 2017

+
+    Write-LogPassThru -Message "Upload complete."
+}
+catch


I wonder if ErrorActionPreference should be set to STOP #Resolved

Fixed.

In reply to: 94475385 [](ancestors = 94475385)

JamesWTruher · Jan 4, 2017

adityapatwardhan · Jan 4, 2017

@lzybkr Merge conflict is solved. Change is ready to merge.

adityapatwardhan · Jan 5, 2017

@lzybkr All checks have passed. Is it ok to merge?

This script downloads the latest nightly build package and executes the tests on it. It also downloads all necessary tools and then uploads the results to Coveralls.io. The badge for coverage is posted on README.md

Code coverage automation script

946e865

This script downloads the latest nightly build package and executes the tests on it. It also downloads all necessary tools and then uploads the results to Coveralls.io. The badge for coverage is posted on README.md

msftclas added the cla-not-required label Dec 21, 2016

lzybkr reviewed Dec 22, 2016

View reviewed changes

lzybkr assigned JamesWTruher Dec 22, 2016

Addressed code review comments and added readme.md file

64ed219

Addressed CR comments about log file location, logging function and usage of powershell.version file. Also added a README.md file explaining the process.

PowerShellTeam added the Review - Needed The PR is being reviewed label Dec 22, 2016

adityapatwardhan added 3 commits December 22, 2016 12:08

Fixed bug in logging

8094fc5

Added upload completed message

d0981b6

Fixed get git version commandline bug

6ed51f4

Fix the bug in invoking $PSversionTable. Added -force to expand-archive cmdlets.

JamesWTruher reviewed Jan 3, 2017

View reviewed changes

Addressed CR feedback

b6ef018

lzybkr and others added 2 commits January 4, 2017 11:46

Fix spelling

d0c9bc3

Merge branch 'master' into CodeCoverageAutomation

573ffa0

Correct outdated step in README.md

0322e5b

lzybkr merged commit 1264eed into PowerShell:master Jan 5, 2017

adityapatwardhan deleted the CodeCoverageAutomation branch January 6, 2017 01:03

		$openCoverZip = 'https://ci.appveyor.com/api/projects/PowerShell/powershell-f975h/artifacts/OpenCover.zip'


		New-Item "$PSScriptRoot\logs.txt" -Force


		"Test run done.!!" \| Tee-Object -FilePath "$PSScriptRoot\logs.txt" -Append

		$powershellVersionString = (Get-Content "$psBinPath\publish\powershell.version")

Search code, repositories, users, issues, pull requests...

Conversation

adityapatwardhan commented Dec 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Dec 22, 2016

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher Jan 3, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher commented Jan 4, 2017

Uh oh!

adityapatwardhan commented Jan 4, 2017

Uh oh!

adityapatwardhan commented Jan 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading

JamesWTruher Jan 3, 2017 •

edited by adityapatwardhan

Loading