Fix OpenCover.console.exe parameter ordering issue.#2854
Merged
daxian-dbw merged 3 commits intoDec 8, 2016
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:OpenCoverUpdatesadityapatwardhan/PowerShell:OpenCoverUpdatesCopy head branch name to clipboard
Merged
Fix OpenCover.console.exe parameter ordering issue.#2854daxian-dbw merged 3 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:OpenCoverUpdatesadityapatwardhan/PowerShell:OpenCoverUpdatesCopy head branch name to clipboard
daxian-dbw merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:OpenCoverUpdatesadityapatwardhan/PowerShell:OpenCoverUpdatesCopy head branch name to clipboard
Conversation
The targetargs parameter needs to be at the end, otherwise everything after that is considered as part of targetargs.
Member
Author
|
@JamesWTruher can you have a look at this please? |
Collaborator
|
|
daxian-dbw
reviewed
Dec 8, 2016
| # the order seems to be important | ||
| $openCoverArgs = "-target:$target","-targetargs:""$targetArgString""","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all" | ||
| # the order seems to be important. Always keep -targetargs as the last parameter. | ||
| $openCoverArgs = "-target:$target","-register:user","-output:${outputLog}","-nodefaultfilters","-oldstyle","-hideskipped:all","-targetargs:""$targetArgString""" |
Member
There was a problem hiding this comment.
Can we use `" instead of ""? I think the readability is better with it.
Member
Author
There was a problem hiding this comment.
Unfortunately OpenCover.console.exe is very finicky about ", it has to be exactly what it expects.
Member
There was a problem hiding this comment.
I means using `" to represent a literal double quote character within a double quoted string. It will still be a double quote when the string is evaluated.
daxian-dbw
approved these changes
Dec 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The targetargs parameter needs to be at the end, otherwise everything
after that is considered as part of targetargs.