Add ErrorAction Stop to DeviceGuard function#2825
Merged
lzybkr merged 1 commit intoDec 2, 2016
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:DeviceGuardFailureadityapatwardhan/PowerShell:DeviceGuardFailureCopy head branch name to clipboard
Merged
Add ErrorAction Stop to DeviceGuard function#2825lzybkr merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:DeviceGuardFailureadityapatwardhan/PowerShell:DeviceGuardFailureCopy head branch name to clipboard
lzybkr merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:DeviceGuardFailureadityapatwardhan/PowerShell:DeviceGuardFailureCopy head branch name to clipboard
Conversation
A non-terminating error is thrown when the namespace does not exist by Get-CimInstance. The namespace is not present on OS versions below Windows 10. It is not caught in the try-catch unless ErrorAction Stop is added.
Member
Author
|
@mirichmo Can you review, since you added this file initially? |
mirichmo
approved these changes
Dec 2, 2016
Member
|
I'll merge it once Travis succeeds |
Member
Author
|
@mirichmo All checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-terminating error is thrown when the namespace does not exist by
Get-CimInstance. The namespace is not present on OS versions below Windows
10. It is not caught in the try-catch unless ErrorAction Stop is added.
Also fixed a typo in test name.