Fix Unicode in license_thirdparty_proprietary.txt#2857
Merged
daxian-dbw merged 1 commit intoDec 8, 2016
PowerShell:masterPowerShell/PowerShell:masterfrom
rmunn:fix-unicode-in-license-filermunn/PowerShell:fix-unicode-in-license-fileCopy head branch name to clipboard
Merged
Fix Unicode in license_thirdparty_proprietary.txt#2857daxian-dbw merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom rmunn:fix-unicode-in-license-filermunn/PowerShell:fix-unicode-in-license-fileCopy head branch name to clipboard
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
rmunn:fix-unicode-in-license-filermunn/PowerShell:fix-unicode-in-license-fileCopy head branch name to clipboard
Conversation
This file contained many occurrences of U+F0A7, a character from the designated Private Use Area, so its meaning is not defined and fonts can assign any symbol to that character. Since the person who originally wrote this file works at Microsoft, it seems reasonable to assume that he was using the Wingdings font, which has a bullet character at U+F0A7. Thus, replacing these characters with the proper Unicode bullet (U+2022) seems the right way to fix this.
|
Hi @rmunn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file contained many occurrences of U+F0A7, a character from the designated Private Use Area, so its meaning is not defined and fonts can assign any symbol to that character. Since the person who originally wrote this file works at Microsoft, it seems reasonable to assume that he was using the Wingdings font, which has a bullet character at U+F0A7 according to this source and this source. Thus, replacing these characters with the proper Unicode bullet (U+2022) seems the right way to fix this.