Migrate from tendermint-rs to cometbft-rs
#1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
Oct 23, 2025
tony-iqlusion
added a commit
that referenced
this pull request
Oct 23, 2025
To unblock the upgrade to `cometbft-rs` (#1124), this removes the only usage of `cosmrs`, which is for formatting Cosmos JSON public keys.
tony-iqlusion
added a commit
that referenced
this pull request
Oct 23, 2025
To unblock the upgrade to `cometbft-rs` (#1124), this removes the only usage of `cosmrs`, which is for formatting Cosmos JSON public keys.
tony-iqlusion
added a commit
that referenced
this pull request
Oct 23, 2025
Shella
reviewed
Oct 27, 2025
Member
Shella
left a comment
There was a problem hiding this comment.
Huge diff! Overall have a few comments on some weirdness but as long as the compiler approves and someone has tested in a staging/prod env then I say let's land it.
| pub use super::ed25519; | ||
| pub use k256::ecdsa; | ||
| use tendermint_proto as proto; | ||
| // use cometbft_proto as proto; |
Member
There was a problem hiding this comment.
unused dep, curious if todo below will be fixed in this diff.
| /// | ||
| /// Adapted from: | ||
| /// <https://github.com/cometbft/cometbft/blob/27d2a18/proto/tendermint/types/types.proto#L13> | ||
| /// <https://github.com/cometbft/cometbft/blob/27d2a18/proto/cometbft/types/types.proto#L13> |
|
|
||
| Ok(Response::SignedRawBytes(sig.into())) | ||
| } | ||
| // TODO(tarcieri): vendor protos |
Member
There was a problem hiding this comment.
just checking looks like vendor protos are WIP?
Member
Author
There was a problem hiding this comment.
Yes, will get fixed in a followup
Shella
approved these changes
Oct 27, 2025
tony-iqlusion
added a commit
that referenced
this pull request
Nov 7, 2025
### Added - Support for Celestia's extension to sign raw bytes with consensus keys (#969, #1134) - `protocol_version = "v0.38"` configuration option for validators (#1138) - Support for expanded Ed25519 keys including the exported YubiHSM format (#1096) ### Changed - Bump Rust edition to 2024; MSRV 1.85 (#984, #967) - Migrate (back) to `ed25519-dalek` (#991) - Migrate from `tendermint-p2p` to `cometbft-p2p` (#1084) - Migrate from `tendermint-rs` to (iq-)`cometbft-rs` (#1124, #1129, #1139) - Bump `prost` and `tonic` to v0.14 (#1136) - Bump `abscissa_core` to v0.9 (#1146) ### Removed - `cosmrs` dependency (#1125)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #975, which replaces the EOL
tendermint-*crates with unreleasedcometbft-*ones.This temporarily disables raw byte signing as added in #969. To add it back, we'll need to vendor the relevant protos.