Support for signing raw bytes with consensus keys #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
reviewed
Aug 4, 2025
| chain, | ||
| prelude::*, | ||
| privval::{SignableMsg, SignedMsgType}, | ||
| privval::{ConsensusMsg, ConsensusMsgType}, |
There was a problem hiding this comment.
this looks like a breaking change, do we need to change these? or make the PR only additive?
Member
Author
There was a problem hiding this comment.
This project is effectively a [[bin]] crate so it doesn't matter
8420b0c to
572ff17
Compare
Implements support for the cometbft/cometbft#5126 interface for signing arbitrary domain-separated messages using a validator's consensus key
572ff17 to
7521278
Compare
tony-iqlusion
commented
Oct 23, 2025
Comment on lines
+75
to
+77
| [patch.crates-io.tendermint-proto] | ||
| git = "https://github.com/rach-id/tendermint-rs.git" | ||
| branch = "rachid/generate-latest-v38-protos" |
Member
Author
There was a problem hiding this comment.
I'll have to vendor the protos to get rid of this, I guess
Shella
approved these changes
Oct 23, 2025
tony-iqlusion
added a commit
that referenced
this pull request
Oct 30, 2025
Re-enables support for signing raw bytes using a consensus key, originally added in #969. That PR originally sourced its protos via git from: https://github.com/rach-id/tendermint-rs/commits/rachid/generate-latest-v38-protos To avoid the git dependency, this vendors the relevant protos, until such a time that they can be merged into CometBFT properly, i.e.: cometbft/cometbft#5138
tony-iqlusion
added a commit
that referenced
this pull request
Oct 30, 2025
Re-enables support for signing raw bytes using a consensus key, originally added in #969. That PR originally sourced its protos via git from: https://github.com/rach-id/tendermint-rs/commits/rachid/generate-latest-v38-protos To avoid the git dependency, this vendors the relevant protos, until such a time that they can be merged into CometBFT properly, i.e.: cometbft/cometbft#5138
tony-iqlusion
added a commit
that referenced
this pull request
Oct 30, 2025
Re-enables support for signing raw bytes using a consensus key, originally added in #969. That PR originally sourced its protos via git from: https://github.com/rach-id/tendermint-rs/commits/rachid/generate-latest-v38-protos To avoid the git dependency, this vendors the relevant protos, until such a time that they can be merged into CometBFT properly, i.e.: cometbft/cometbft#5138
Merged
tony-iqlusion
added a commit
that referenced
this pull request
Nov 7, 2025
### Added - Support for Celestia's extension to sign raw bytes with consensus keys (#969, #1134) - `protocol_version = "v0.38"` configuration option for validators (#1138) - Support for expanded Ed25519 keys including the exported YubiHSM format (#1096) ### Changed - Bump Rust edition to 2024; MSRV 1.85 (#984, #967) - Migrate (back) to `ed25519-dalek` (#991) - Migrate from `tendermint-p2p` to `cometbft-p2p` (#1084) - Migrate from `tendermint-rs` to (iq-)`cometbft-rs` (#1124, #1129, #1139) - Bump `prost` and `tonic` to v0.14 (#1136) - Bump `abscissa_core` to v0.9 (#1146) ### Removed - `cosmrs` dependency (#1125)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for the cometbft/cometbft#5126 interface for signing arbitrary domain-separated messages using a validator's consensus key