Use ed25519-dalek's ExpandedSecretKey #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135bb27 to
f0c1498
Compare
tony-iqlusion
approved these changes
Nov 7, 2025
This was referenced Nov 7, 2025
Contributor
Author
|
huge thanks for the review @tony-iqlusion |
Member
|
Note: tested live on the Celestia |
Merged
tony-iqlusion
added a commit
that referenced
this pull request
Nov 7, 2025
### Added - Support for Celestia's extension to sign raw bytes with consensus keys (#969, #1134) - `protocol_version = "v0.38"` configuration option for validators (#1138) - Support for expanded Ed25519 keys including the exported YubiHSM format (#1096) ### Changed - Bump Rust edition to 2024; MSRV 1.85 (#984, #967) - Migrate (back) to `ed25519-dalek` (#991) - Migrate from `tendermint-p2p` to `cometbft-p2p` (#1084) - Migrate from `tendermint-rs` to (iq-)`cometbft-rs` (#1124, #1129, #1139) - Bump `prost` and `tonic` to v0.14 (#1136) - Bump `abscissa_core` to v0.9 (#1146) ### Removed - `cosmrs` dependency (#1125)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another stab at using the prehashed, expanded secret keys.
I tried to take: #978 (comment) into the account, so now it's using the ExpandedSecretKey across the board, trying to guess the type/encoding based on the supplied keylength.
One thing to note is that I split loading signing keys and identity keys, keeping this coupled would require some changes to the p2p crate, which I wanted to avoid.
previous prs: