Add protocol_version = "v0.38"
#1138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to migrate to CometBFT V1 at some point, which contains breaking changes.
Rather than getting rid of the
protocol_versionfield under[validator], it can instead be repurposed to assist in the migration.First we need to get people to update it to
v0.38, which is the proto version we source from (iq-)cometbft-rs.After that we can add support for
v1, and eventually make it the default.