Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Aug 11, 2025

This PR adds support for CometBFT https://github.com/cometbft/cometbft/releases/tag/v1.0.0. It depends on an unreleased version of cometbft-rs, the release for which needs to be coordinated with ICL.

This feature was verified to work on Injective mainnet.

Also

  • the support for CosmosJson is dropped because cosmjs needs to be updated to work with cometbft-rs keys.
  • skip_extension_signing attribute is ignored, but should be respected.

@tony-iqlusion
Copy link
Member

It further renames Tendermint KMS to CometBFT KMS because the former is no longer maintained.

Renaming an entire project is something that should be discussed in its own separate issue, not something done as a secondary objective in what is effectively a feature PR.

Can you leave the name as-is for now and open a discussion issue? It will also make the PR and its subsequent followup much more manageable to review.

@melekes
Copy link
Contributor Author

melekes commented Aug 11, 2025

Re:

thread 'test_buffer_underflow_sign_proposal' panicked at tests/integration.rs:660:28:
called `Result::unwrap()` on an `Err` value: Os { code: 54, kind: ConnectionReset, message: "Connection reset by peer" }

Q: Is there a way to regenerate "tests/support/buffer-underflow-proposal.bin"?

@melekes
Copy link
Contributor Author

melekes commented Aug 11, 2025

It further renames Tendermint KMS to CometBFT KMS because the former is no longer maintained.

Renaming an entire project is something that should be discussed in its own separate issue, not something done as a secondary objective in what is effectively a feature PR.

Can you leave the name as-is for now and open a discussion issue? It will also make the PR and its subsequent followup much more manageable to review.

Done ✅

Cargo.toml Show resolved Hide resolved
@tony-iqlusion
Copy link
Member

@melekes are there any plans to publish a new prerelease of at least cometbft-proto any time soon?

@sryps
Copy link

sryps commented Aug 27, 2025

@melekes are there any plans to publish a new prerelease of at least cometbft-proto any time soon?

@tony-iqlusion
Not sure, we are no longer stewards of cometbft-rs so any request would have to go to ICF.

@tony-iqlusion
Copy link
Member

@sryps is there someone specific at the ICF I should ping about that?

In the meantime I will try to get this landed, but vendoring the relevant protos for now.

@sryps
Copy link

sryps commented Oct 23, 2025

@sryps is there someone specific at the ICF I should ping about that?

In the meantime I will try to get this landed, but vendoring the relevant protos for now.

Im not sure, Barry with ICL maybe? I dont deal with anything on that end myself.

@aljo242
Copy link

aljo242 commented Nov 6, 2025

@tony-iqlusion feel free to ping me on what needs to be done in Comet-rs

@tony-iqlusion
Copy link
Member

We've migrated to a fork of cometbft-rs: #1124, #1129, #1139

Unfortunately we can't support CometBFT V1 yet due to breaking changes to the protocol: #1132

We'll need to have multi-version support: #976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.