-
Notifications
You must be signed in to change notification settings - Fork 142
feat!: CometBFT v1 support #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renaming an entire project is something that should be discussed in its own separate issue, not something done as a secondary objective in what is effectively a feature PR. Can you leave the name as-is for now and open a discussion issue? It will also make the PR and its subsequent followup much more manageable to review. |
|
Re: Q: Is there a way to regenerate "tests/support/buffer-underflow-proposal.bin"? |
Done ✅ |
|
@melekes are there any plans to publish a new prerelease of at least |
@tony-iqlusion |
|
@sryps is there someone specific at the ICF I should ping about that? In the meantime I will try to get this landed, but vendoring the relevant protos for now. |
Im not sure, Barry with ICL maybe? I dont deal with anything on that end myself. |
|
@tony-iqlusion feel free to ping me on what needs to be done in Comet-rs |
This PR adds support for CometBFT https://github.com/cometbft/cometbft/releases/tag/v1.0.0. It depends on an unreleased version of cometbft-rs, the release for which needs to be coordinated with ICL.
This feature was verified to work on Injective mainnet.
Also
CosmosJsonis dropped becausecosmjsneeds to be updated to work with cometbft-rs keys.skip_extension_signingattribute is ignored, but should be respected.