Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8 #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8 #9509

wants to merge 13 commits into from

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 6, 2024 •
edited
Loading

BREAKING CHANGE:
Changes a rule's default option.

PR Checklist

Overview

Changes the option's default from true to false and updates docs + tests.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v8 July 6, 2024 19:37
@netlify Netlify
Copy link

netlify bot commented Jul 6, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c71bbec
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6692c40db83fef0008aa03b9
😎 Deploy Preview https://deploy-preview-9509--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title No floating promises v8 check thenables feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8 Jul 6, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 150fd5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JoshuaKGoldberg @bradzacher
fix(utils): context.parserPath may be undefined (typescript-eslint#9486)
103de6e 
* fix(utils): context.parserPath may be undefined

* Update packages/utils/src/eslint-utils/getParserServices.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 6, 2024
abrahamguo and others added 10 commits July 7, 2024 23:50
@abrahamguo
fix(eslint-plugin): [no-floating-promises] add suggestions to tests…
3c6290d 
… from typescript-eslint#9263 `checkThenables` (typescript-eslint#9515)

add suggestions
@y-hsgw
fix(website): react key error on internal pages of website (typescrip…
03fe3db 
…t-eslint#9506)

fix: React key error
@auvred
fix(eslint-plugin): [restrict-template-expressions] don't report tupl…
7b13dae 
…es if `allowArray` option is enabled (typescript-eslint#9492)
@typescript-eslint
chore(release): publish 7.16.0
e803c50
@dasa
chore(eslint-plugin): [no-unnecessary-parameter-property-assignment] …
bebbd0c 
…remove `fixable` from `meta` (typescript-eslint#9527)

chore: remove `fixable` from `meta`

No fixer is actually present.

Ref: typescript-eslint#8903 (comment)
@renovate
chore(deps): update dependency knip to v5.24.0 (typescript-eslint#9534)
c0eab00 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@auvred
chore: don't install dependencies in "Semantic breaking change PR" wo…
0d4b098 
…rkflow (typescript-eslint#9533)
@auvred
chore: revert "chore: don't install dependencies in "Semantic breakin…
d9dba42 
…g change PR" workflow (typescript-eslint#9533)" (typescript-eslint#9535)

Revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (typescript-eslint#9533)"

This reverts commit 0d4b098.
@typescript-eslint
chore: update sponsors (typescript-eslint#9545)
3709c0a 
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
@abrahamguo
chore: enable prefer-arrow-callback (typescript-eslint#9548)
8ceca98 
prefer-arrow-callback
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 13, 2024 16:19
@Josh-Cena
Copy link
Member

Branch seems corrupted, could you rebase?

@JoshuaKGoldberg
Copy link
Member Author

Huh, will fix. Sorry about that.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the no-floating-promises-v8-check-thenables branch from c71bbec to d5e4c8c Compare July 13, 2024 18:15
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-floating-promises-v8-check-thenables branch July 13, 2024 18:16
@JoshuaKGoldberg JoshuaKGoldberg restored the no-floating-promises-v8-check-thenables branch July 13, 2024 18:16
@JoshuaKGoldberg
Copy link
Member Author

🤷 recreated in #9559.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-floating-promises-v8-check-thenables branch January 16, 2025 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-floating-promises] Disable checkThenables by default in v8
6 participants
@JoshuaKGoldberg @Josh-Cena @abrahamguo @y-hsgw @auvred @dasa
Morty Proxy This is a proxified and sanitized view of the page, visit original site.