Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: don't install dependencies in "Semantic breaking change PR" workflow #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore: don't install dependencies in "Semantic breaking change PR" workflow #9533

merged 1 commit into from
Jul 10, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 10, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b751bb8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668e551c2a12030008c3aeeb
😎 Deploy Preview https://deploy-preview-9533--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b751bb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher merged commit 0d4b098 into typescript-eslint:main Jul 10, 2024
64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 10, 2024
Merged
3 tasks
auvred added a commit to auvred/typescript-eslint that referenced this pull request Jul 10, 2024
@auvred
Revert "chore: don't install dependencies in "Semantic breaking chang…
b3cee62 
…e PR" workflow (typescript-eslint#9533)"

This reverts commit 0d4b098.
@auvred auvred mentioned this pull request Jul 10, 2024
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this pull request Jul 10, 2024
@auvred
chore: revert "chore: don't install dependencies in "Semantic breakin…
d9dba42 
…g change PR" workflow (#9533)" (#9535)

Revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (#9533)"

This reverts commit 0d4b098.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: don't install dependencies for the entire repo in "Semantic Breaking Change PR" workflow
2 participants
@auvred @bradzacher
Morty Proxy This is a proxified and sanitized view of the page, visit original site.