Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (#9533)" #9535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 10, 2024

PR Checklist

Overview

Oops 😬 This PR reverts my previous PR #9533
See #9530 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@auvred auvred changed the title choer: revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (#9533)" chore: revert "chore: don't install dependencies in "Semantic breaking change PR" workflow (#9533)" Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b3cee62
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668ebca1a78612000814d9f8
😎 Deploy Preview https://deploy-preview-9535--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 10, 2024

@JoshuaKGoldberg
Copy link
Member

If I had a nickel for every main failure caused by difficulties in testing GHA... I could reimburse myself for all the times I've broken main because of that.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d9dba42 into typescript-eslint:main Jul 10, 2024
65 of 67 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.