Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(eslint-plugin): [restrict-template-expressions] don't report tuples if allowArray option is enabled #9492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix(eslint-plugin): [restrict-template-expressions] don't report tuples if allowArray option is enabled #9492

merged 1 commit into from
Jul 8, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 4, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit acf626a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668668628c5bc20008c3d0e1
😎 Deploy Preview https://deploy-preview-9492--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit acf626a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (7e2b77d) to head (acf626a).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9492   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         417      417           
  Lines       14413    14413           
  Branches     4208     4208           
=======================================
  Hits        12721    12721           
  Misses       1372     1372           
  Partials      320      320
Flag Coverage Δ
unittest 88.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <100.00%> (ø)

kirkwaiblinger
kirkwaiblinger approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darth vader dancing

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 7, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great testing! 🧪

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7b13dae into typescript-eslint:main Jul 8, 2024
66 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [restrict-template-expressions] allowArrays errors on "as const" arrays.
3 participants
@auvred @JoshuaKGoldberg @kirkwaiblinger
Morty Proxy This is a proxified and sanitized view of the page, visit original site.