Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add vision label detection#2237

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-label-detectiondaspecster/google-cloud-python:vision-label-detectionCopy head branch name to clipboard
Sep 15, 2016
Merged

Add vision label detection#2237
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-label-detectiondaspecster/google-cloud-python:vision-label-detectionCopy head branch name to clipboard

Conversation

@daspecster

@daspecster daspecster commented Sep 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Based off of #2236.

I was able to DRY up the requests code for the EntityAnnotation based detection types.

✅ Waiting for #2236 before rebasing.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@daspecster daspecster force-pushed the vision-label-detection branch 2 times, most recently from 8395fa7 to c49f0c2 Compare September 12, 2016 14:52
@daspecster daspecster mentioned this pull request Sep 12, 2016
Merged
@daspecster daspecster force-pushed the vision-label-detection branch from c49f0c2 to 8669d3a Compare September 12, 2016 21:58
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 12, 2016
@daspecster

daspecster commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver LMKWYT!

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
Comment thread google/cloud/vision/entity.py Outdated
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
Comment thread google/cloud/vision/entity.py Outdated
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = Bounds.from_api_repr(response.get('boundingPoly', {}))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google/cloud/vision/geometry.py
vertices.append(Vertex(vertex.get('x', None),
vertex.get('y', None)))
vertices = [Vertex(vertex.get('x', None), vertex.get('y', None)) for
vertex in response_vertices.get('vertices', [])]

This comment was marked as spam.

Sign in to view

@daspecster daspecster force-pushed the vision-label-detection branch from c71fa03 to f75f96d Compare September 14, 2016 19:33
@daspecster

daspecster commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver anything else?

@tseaver

tseaver commented Sep 14, 2016

Copy link
Copy Markdown
Contributor

LGTM pending Travis.

@daspecster daspecster force-pushed the vision-label-detection branch from f75f96d to 408f929 Compare September 14, 2016 20:43
@daspecster

daspecster commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

Squashed...going to wait for travis one more time.

@daspecster daspecster merged commit 143b0a1 into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster daspecster deleted the vision-label-detection branch January 24, 2017 15:17
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
fix: allow google-cloud-documentai 3.x (#2237)
265858d
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot @chalmerlowe
chore(deps): update dependency certifi to v2025.7.14 (#2237)
4f154e0 
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@tswast @gcf-owl-bot
docs: switch API reference docs to pydata theme (#2237)
6ba8851 
* docs: switch API reference docs to pydata theme

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* use python 3.13 to render the docs

* deploy to github pages

* Revert "🦉 Updates from OwlBot post-processor"

This reverts commit 5b5276b81fb3998e7241401b6cbfc56e172e4831.

* exclude conf.py from owlbot

* remove unneeded replacement

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@release-please
chore(main): release 2.29.0 (#2242)
a69afc4 
🤖 I have created a release *beep* *boop*
---


##
[2.29.0](googleapis/python-bigquery-dataframes@v2.28.0...v2.29.0)
(2025-11-10)


### Features

* Add bigframes.bigquery.st_regionstats to join raster data from Earth
Engine
([#2228](googleapis/python-bigquery-dataframes#2228))
([10ec52f](googleapis/python-bigquery-dataframes@10ec52f))
* Add DataFrame.resample and Series.resample
([#2213](googleapis/python-bigquery-dataframes#2213))
([c9ca02c](googleapis/python-bigquery-dataframes@c9ca02c))
* SQL Cell no longer escapes formatted string values
([#2245](googleapis/python-bigquery-dataframes#2245))
([d2d38f9](googleapis/python-bigquery-dataframes@d2d38f9))
* Support left_index and right_index for merge
([#2220](googleapis/python-bigquery-dataframes#2220))
([da9ba26](googleapis/python-bigquery-dataframes@da9ba26))


### Bug Fixes

* Correctly iterate over null struct values in ManagedArrowTable
([#2209](googleapis/python-bigquery-dataframes#2209))
([12e04d5](googleapis/python-bigquery-dataframes@12e04d5))
* Simplify UnsupportedTypeError message
([#2212](googleapis/python-bigquery-dataframes#2212))
([6c9a18d](googleapis/python-bigquery-dataframes@6c9a18d))
* Support results with STRUCT and ARRAY columns containing JSON
subfields in `to_pandas_batches()`
([#2216](googleapis/python-bigquery-dataframes#2216))
([3d8b17f](googleapis/python-bigquery-dataframes@3d8b17f))


### Documentation

* Switch API reference docs to pydata theme
([#2237](googleapis/python-bigquery-dataframes#2237))
([9b86dcf](googleapis/python-bigquery-dataframes@9b86dcf))
* Update notebook for JSON subfields support in to_pandas_batches()
([#2138](googleapis/python-bigquery-dataframes#2138))
([5663d2a](googleapis/python-bigquery-dataframes@5663d2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseaver tseaver tseaver left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster @tseaver @dhermes @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.