Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Vision text detection#2299

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-text-detectiondaspecster/google-cloud-python:vision-text-detectionCopy head branch name to clipboard
Sep 15, 2016
Merged

Vision text detection#2299
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-text-detectiondaspecster/google-cloud-python:vision-text-detectionCopy head branch name to clipboard

Conversation

@daspecster

Copy link
Copy Markdown
Contributor

Based off #2237.

Adds text detection.

This is the last of the Entity based detections.

Safe Search and Image properties are left.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2016
@daspecster daspecster force-pushed the vision-text-detection branch 2 times, most recently from deeb833 to 8b2e716 Compare September 12, 2016 21:57
Comment thread docs/vision-usage.rst Outdated
>>> image = client.image('./image.jpg')
>>> text = image.detect_text()
>>> text.locale
>>> text[0].locale

This comment was marked as spam.

This comment was marked as spam.

@tseaver

tseaver commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

LGTM: you can address my comments or leave them be, if you think best.

@daspecster daspecster force-pushed the vision-text-detection branch from 8b2e716 to b227338 Compare September 15, 2016 01:24
@daspecster

Copy link
Copy Markdown
Contributor Author

Ok, I updated the code based on your comments. I'll let travis run and then I'll make the next two PRs.

@daspecster daspecster merged commit 51d11da into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
@daspecster daspecster deleted the vision-text-detection branch January 24, 2017 15:17
parthea pushed a commit that referenced this pull request Apr 1, 2026
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.