Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove all sleep() statements from unit tests #2220

Copy link
Copy link

Description

@dhermes
Issue body actions

Without the sleeps, the unit tests are "fast", i.e. they just run without any pauses and take ~1.5 seconds. With the sleeps from the three offending test cases, the unit tests take ~4.5 seconds.

@waprin these are all in gcloud.logging.handlers.transport.test_background_thread. Wanted to assign this to you but can't for some reason? (Never sure how org. vs. project permissions matter for issue assignment.)

Reactions are currently unavailable

Metadata

Metadata

Labels

api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.testing

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.