Full support for DATE, TIME, and DATETIME in BigQuery by garrettjonesgoogle · Pull Request #1819 · googleapis/google-cloud-java

garrettjonesgoogle · Mar 28, 2017

Also:

Using Timestamp instead of Long for timestamp values.
Renaming Date to CivilDate, naming new types in an analogous way, CivilTime and CivilDateTime

garrettjonesgoogle · Mar 28, 2017

Note I have fixed the codacy errors - I'll push them with other PR updates.

Sign in to view

+
+  /**
+   * Creates a {@code QueryParameterValue} object with a type of DATETIME.
+   * Must be in the format "yyyy-MM-dd HH:mm:ss.SSSSSS", e.g. ""2014-08-19 12:41:35.220000".


Sign in to view

+ * and Spanner DATE
+ * (https://cloud.google.com/spanner/docs/data-types#date-type).
+ *
+ * The DATE type represents a logical calendar date, independent of time zone. A DATE value


Sign in to view

+ * Represents a time without timezone, e.g. 07:41:35.220000.
+ *
+ * CivilTime holds values for BigQuery TIME
+ * (https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#time-type).0


Sign in to view

        } else if (value instanceof String) {
          // verify that the String is in the right format
-          timestampFormatter.parseMillis((String) value);
+          Timestamp.parseCloudTimestamp((String) value);


garrettjonesgoogle · Mar 29, 2017

@shinfan PTAL

shinfan · Mar 29, 2017

LGTM

coveralls · Mar 29, 2017

Changes Unknown when pulling fee2415 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

vkedia

I am still looking at Timestamp.java

Sign in to view

+   * @param date civil date
+   */
+  public static CivilDateTime ofDate(CivilDate date) {
+    return ofDateAndTime(date, CivilTime.ofHoursMinutesSecondsNanos(0, 0, 0, 0));


Sign in to view

+  }
+
+  /**
+   * @param dateTime Date plus time: (yyyy-MM-dd HH:mm:ss.SSSSSSSSS) or


Sign in to view

+  }
+
+  /**
+   * Constructs a new CivilDate instance.


Sign in to view

+        nanos = (int) TimeUnit.MILLISECONDS.toNanos(fractionalNumber);
+      } else if (fractional.length() == 6) {
+        nanos = (int) TimeUnit.MICROSECONDS.toNanos(fractionalNumber);
+      } else {


Sign in to view

+    return time;
+  }
+
+  /** Formats the date and time in the format yyyy-MM-dd HH:mm:ss.SSSSSSSSS */


Sign in to view

+  }
+
+  /** Formats the date and time in the format yyyy-MM-dd HH:mm:ss.SSSSSSSSS */
+  public String formatMicroCloudTime() {


Sign in to view

    this.nanos = nanos;
  }

+  public static Timestamp ofTimeMicroseconds(long microseconds) {


Sign in to view

+   */
+  public static CivilDateTime parseDateTime(String dateTime) {
+    String splitToken = " ";
+    if (dateTime.contains("T")) {


Sign in to view

+import java.util.Objects;
+
+/**
+ * Represents a date and time with no timezone, e.g. e.g. 2017-03-17 07:41:35.220000.


Sign in to view

  /** Regexp to split timestamps into date-hour-minute-second and fractional second components. */
-  private static final Pattern FORMAT_REGEXP = Pattern.compile("([^\\.]*)(\\.\\d{0,9})?Z");
+  private static final Pattern FORMAT_REGEXP = Pattern.compile("([^.]*)(\\.\\d{0,9})?Z");
+  private static final String DATE_GROUP = "(\\d{4}-\\d{1,2}-\\d{1,2})";


Sign in to view

+  private static final String DATE_GROUP = "(\\d{4}-\\d{1,2}-\\d{1,2})";
+  private static final String TIME_GROUP = "(\\d{1,2}:\\d{1,2}:\\d{1,2})";
+  private static final String FRACT_GROUP = "\\.(\\d{1,9})";
+  private static final String TZ_GROUP = "([\\-+]\\d{1,2}(?::\\d{1,2})?)";


Sign in to view

+
+  /**
+   * Creates a Timestamp instance from the given string. String is in the format
+   * yyyy-MM-dd HH:mm:ss.SSSSSSZZ. If no timezone is given, UTC is assumed.


Sign in to view

+
+    DateTime dateTime = new DateTime();
+    dateTime = parseTz(dateTime, tz);
+    dateTime = parseDate(dateTime, Preconditions.checkNotNull(date));


Sign in to view

+    return ofTimeSecondsAndNanos(TimeUnit.MILLISECONDS.toSeconds(dateTime.getMillis()), nanos);
+  }
+
+  private static DateTime parseDate(DateTime newDateTime, String dateString) {


Sign in to view

+   * Creates a Timestamp instance from the given string. String is in the format
+   * yyyy-MM-dd HH:mm:ss.SSSSSSZZ. If no timezone is given, UTC is assumed.
+   */
+  public static Timestamp parseCloudTimestamp(String timestamp) {


garrettjonesgoogle · Mar 30, 2017

All so-far-agreed-to feedback has been addressed.

coveralls · Mar 30, 2017

Changes Unknown when pulling 8e26935 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

Sign in to view

   */
  @SuppressWarnings("unchecked")
-  public long getTimestampValue() {
+  public Timestamp getTimestampValue() {


garrettjonesgoogle · Mar 30, 2017

I have pushed some doc improvements, PTAL

coveralls · Mar 30, 2017

Changes Unknown when pulling 3151e09 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle · Mar 31, 2017

@vkedia do you have any other concerns?

vkedia · Mar 31, 2017

Looks good to me.

coveralls · Mar 31, 2017

Changes Unknown when pulling 7a54804 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

coveralls · Apr 1, 2017

Changes Unknown when pulling 3151e09 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

coveralls · Apr 24, 2017

Coverage increased (+0.01%) to 80.903% when pulling 1535cc1 on garrettjonesgoogle:master into 5dae747 on GoogleCloudPlatform:master.

This also changes the JDK distribution from zulu to temurin https://togithub.com/actions/setup-java#eclipse-temurin Source-Link: https://togithub.com/googleapis/synthtool/commit/ef9fe2ef6d92c7ff967d9d4f704035b3f5c9051d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

* ci: javadoc job (JDK 17) in ci.yaml (#1819) This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 * fix javadoc * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <suztomo@google.com>

This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* ci: javadoc job (JDK 17) in ci.yaml (#1819) This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 * fix errors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix error --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu1995 <neenushaji@google.com>

This also changes the JDK distribution from zulu to temurin https://togithub.com/actions/setup-java#eclipse-temurin Source-Link: https://togithub.com/googleapis/synthtool/commit/ef9fe2ef6d92c7ff967d9d4f704035b3f5c9051d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* ci: javadoc job (JDK 17) in ci.yaml (#1819) This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 * docs: fix java 17 doclint errors --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…10.1 (#1819)

This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…10.1 (#1819)

#1819)

garrettjonesgoogle requested review from shinfan, tswast and vkedia March 28, 2017 21:48

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017

shinfan reviewed Mar 28, 2017

View reviewed changes

vkedia reviewed Mar 29, 2017

View reviewed changes

vkedia reviewed Mar 30, 2017

View reviewed changes

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryParameterValue.java

@@ -252,12 +262,28 @@ public static QueryParameterValue time(String value) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vkedia reviewed Mar 30, 2017

View reviewed changes

garrettjonesgoogle force-pushed the master branch from 3151e09 to 7a54804 Compare March 31, 2017 18:56

garrettjonesgoogle force-pushed the master branch 2 times, most recently from b35947a to 3151e09 Compare March 31, 2017 23:34

Reducing visibility of some things, adding @internalapi

1535cc1

garrettjonesgoogle force-pushed the master branch from 3151e09 to 1535cc1 Compare April 24, 2017 19:16

garrettjonesgoogle closed this Apr 24, 2017

garrettjonesgoogle mentioned this pull request May 8, 2017

BigQuery: Support Date, Time, and DateTime types in FieldValue #1792

Closed

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

chore: Only enable renovate bot for CVE PRs (#1819)

28099c7

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

chore: Only enable renovate bot for CVE PRs (#1819)

652fc11

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

ci: javadoc job (JDK 17) in ci.yaml (googleapis#1819) (googleapis#1276)

485d907

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(main): release 2.24.2 (googleapis#1819)

98354b8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

deps: update dependency org.junit.vintage:junit-vintage-engine to v5.…

af84aa3

…10.1 (#1819)

meltsufin pushed a commit that referenced this pull request May 1, 2026

deps: update dependency org.junit.vintage:junit-vintage-engine to v5.…

00dbcf7

…10.1 (#1819)

meltsufin pushed a commit that referenced this pull request May 2, 2026

deps: update dependency com.google.cloud:google-cloud-trace to v2.49.0 (

508b79f

#1819)

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

garrettjonesgoogle commented Mar 28, 2017

Uh oh!

garrettjonesgoogle commented Mar 28, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Mar 29, 2017

Uh oh!

shinfan commented Mar 29, 2017

Uh oh!

coveralls commented Mar 29, 2017

Uh oh!

vkedia left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!