Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix directory listing with leading slash#1644

Merged
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
jean-philippe-martin:jp_list_directoryjean-philippe-martin/gcloud-java:jp_list_directoryCopy head branch name to clipboard
Feb 22, 2017
Merged

Fix directory listing with leading slash#1644
garrettjonesgoogle merged 1 commit into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
jean-philippe-martin:jp_list_directoryjean-philippe-martin/gcloud-java:jp_list_directoryCopy head branch name to clipboard

Conversation

@jean-philippe-martin

Copy link
Copy Markdown

newDirectoryStream("dir1/") and newDirectoryStream("/dir1/") should return the
same result. Added a test to show they didn't, then fixed it
so the test passes.

Thanks to @tomwhite for identifying the problem and suggesting the fix (in #1519).

newDirectoryStream("dir1/") and newDirectoryStream("/dir1/") should
return the
same result. Added a test to show they didn't, then fixed it
so the test passes.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2017
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.004%) to 81.113% when pulling da3724f on jean-philippe-martin:jp_list_directory into e61ca31 on GoogleCloudPlatform:master.

@garrettjonesgoogle garrettjonesgoogle merged commit 0fb03eb into googleapis:master Feb 22, 2017
@jean-philippe-martin

Copy link
Copy Markdown
Author

great, thank you!

@jean-philippe-martin jean-philippe-martin deleted the jp_list_directory branch February 22, 2017 23:56
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
* fix(doc): Add discriptions for TransactionCallable interface

* chore: generate libraries at Mon Oct 28 22:49:19 UTC 2024

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
suztomo pushed a commit that referenced this pull request Mar 30, 2026
newDirectoryStream("dir1/") and newDirectoryStream("/dir1/") should
return the
same result. Added a test to show they didn't, then fixed it
so the test passes.
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
newDirectoryStream("dir1/") and newDirectoryStream("/dir1/") should
return the
same result. Added a test to show they didn't, then fixed it
so the test passes.
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.