Replace DateTime with Timestamp by shinfan · Pull Request #1947 · googleapis/google-cloud-java

shinfan · Apr 19, 2017

Fixes #1920

Sign in to view

    assertThat(Timestamp.MAX_VALUE.getNanos()).isEqualTo(999999999);
  }

+  @Test


Sign in to view

  }
-
-  @Test
-  public void testRunInTransaction() {


Sign in to view

+   *
+   * @throws IllegalArgumentException if the timestamp is outside the representable range
+   */
+  public static Timestamp ofTimeMicroseconds(long microseconds) {


shinfan · Apr 19, 2017

PTAL

coveralls · Apr 19, 2017

Coverage decreased (-0.004%) to 80.836% when pulling 43e0919 on shinfan:datastore into ff8376e on GoogleCloudPlatform:master.

coveralls · Apr 19, 2017

Coverage decreased (-0.01%) to 80.828% when pulling 43e0919 on shinfan:datastore into ff8376e on GoogleCloudPlatform:master.

garrettjonesgoogle

LGTM after you fix the doc nits

Sign in to view

    return new Timestamp(seconds, nanos);
  }

+  /**


Sign in to view

+    return new Timestamp(seconds, nanos);
+  }
+
+  /**


* feat: Add sample code for connection pooling * Fix header * chore: generate libraries at Wed Aug 20 23:03:06 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

* chore(bazel): update protobuf to v3.21.12 PiperOrigin-RevId: 503267695 Source-Link: googleapis/googleapis@c790590 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b98230b9e68a3828cf138296e9a20e03749ae0a0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjk4MjMwYjllNjhhMzgyOGNmMTM4Mjk2ZTlhMjBlMDM3NDlhZTBhMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

) (#2460) Source-Link: googleapis/synthtool@349943b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:033161f610016d155d58f96769ad5a821d203824684e8a13fc50be8c25a5f9cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

) (#3227) * chore: adding 'infrastructure-public-image-' tags for owlbot-java (#1947) Source-Link: googleapis/synthtool@349943b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:033161f610016d155d58f96769ad5a821d203824684e8a13fc50be8c25a5f9cf * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add sample code for connection pooling * Fix header * chore: generate libraries at Wed Aug 20 23:03:06 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

…0.6 (googleapis#1947)

) (#2490) * chore: adding 'infrastructure-public-image-' tags for owlbot-java (#1947) Source-Link: googleapis/synthtool@349943b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:033161f610016d155d58f96769ad5a821d203824684e8a13fc50be8c25a5f9cf * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sydney Munro <97561403+sydney-munro@users.noreply.github.com>

* docs: Adding samples for creating and updating Kinesis ingestion topics * style: Format AdmitIT * style: Re-format AdmitIT * docs: Fix ingestion topic deletion in test * docs: Add test for updating existing ingestion settings and verify the actual results of topic creation and updating * docs: Use response to verify ingestion settings update * style: fix formatting in tests * docs: Update AdminIT test to check for correct topic name * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: Adding samples for creating and updating Kinesis ingestion topics * style: Format AdmitIT * style: Re-format AdmitIT * docs: Fix ingestion topic deletion in test * docs: Add test for updating existing ingestion settings and verify the actual results of topic creation and updating * docs: Use response to verify ingestion settings update * style: fix formatting in tests * docs: Update AdminIT test to check for correct topic name * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

replace DateTime with Timestamp

d4563d6

shinfan requested review from garrettjonesgoogle and michaelbausor April 19, 2017 19:34

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017

garrettjonesgoogle reviewed Apr 19, 2017

View reviewed changes

shinfan added 2 commits April 19, 2017 13:17

Update

9f28287

fix format

43e0919

garrettjonesgoogle reviewed Apr 19, 2017

View reviewed changes

Fix docs

2bcd723

shinfan merged commit 0c2a6cd into googleapis:master Apr 19, 2017

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

deps: update dependency org.testcontainers:testcontainers-bom to v1.2…

1331ee1

…0.6 (googleapis#1947)

meltsufin pushed a commit that referenced this pull request May 2, 2026

deps: update opentelemetry.version to v1.45.0 (#1947)

1c00bba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace DateTime with Timestamp#1947

Replace DateTime with Timestamp#1947
shinfan merged 4 commits into
googleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:datastoreshinfan/gcloud-java:datastoreCopy head branch name to clipboard

shinfan commented Apr 19, 2017 •

edited

Loading

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 19, 2017

Uh oh!

coveralls commented Apr 19, 2017

Uh oh!

coveralls commented Apr 19, 2017

Uh oh!

garrettjonesgoogle left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

shinfan commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Apr 19, 2017

Uh oh!

coveralls commented Apr 19, 2017

Uh oh!

coveralls commented Apr 19, 2017

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shinfan commented Apr 19, 2017 •

edited

Loading