Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[main] Source code updates from dotnet/roslyn - #3957

#3957
Merged
ViktorHofer merged 11 commits into
maindotnet/dotnet:mainfrom
darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dcdotnet/dotnet:darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dcCopy head branch name to clipboard
Dec 19, 2025
Merged

[main] Source code updates from dotnet/roslyn#3957
ViktorHofer merged 11 commits into
maindotnet/dotnet:mainfrom
darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dcdotnet/dotnet:darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dcCopy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/roslyn

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/roslyn:bf35fe58e593ac0ac74c05bfa6e4719b85772da0..https://github.com/dotnet/dotnet:darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dc

@dotnet-maestro

dotnet-maestro Bot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@ViktorHofer

Copy link
Copy Markdown
Member

@jjonescz this one is now up-to-date and doesn't show the previous issue anymore. But there are new issues:

CSC : error CS1566: Error reading resource 'Microsoft.VisualStudio.IntegrationTestService.vsix' -- 'Could not find a part of the path 'D:\a_work\1\s\src\roslyn\artifacts\VSSetup\Release\Microsoft.VisualStudio.IntegrationTestService.vsix'.' [D:\a_work\1\s\src\roslyn\src\VisualStudio\IntegrationTest\Harness\XUnit\Microsoft.VisualStudio.Extensibility.Testing.Xunit.csproj]

We probably need to condition this test project out when building inside the VMR: DotNetBuildFromVMR=true

The other one is in runtime:

D:\a_work\1\s\src\runtime\eng\AcquireWasiSdk.targets(45,5): error MSB3073: The command "powershell -NonInteractive -command "& D:\a_work\1\s\src\runtime\eng\download-wasi-sdk.ps1 -WasiSdkUrl https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-25/wasi-sdk-25.0-x86_64-windows.tar.gz -WasiSdkVersion 25.0 -WasiSdkPath D:\a_work\1\s\src\runtime\artifacts\wasi-sdk; Exit $LastExitCode "" exited with code 52. [D:\a_work\1\s\src\runtime\src\mono\mono.proj]

Is that the powershell policy change thing that people mentioned in chat?

@jjonescz

Copy link
Copy Markdown
Member

We probably need to condition this test project out when building inside the VMR: DotNetBuildFromVMR=true

That needs cherry pick of the last commit from #3921

@ViktorHofer
ViktorHofer enabled auto-merge (squash) December 19, 2025 10:42
@jjonescz

jjonescz commented Dec 19, 2025

Copy link
Copy Markdown
Member

src/templating/src/Microsoft.TemplateEngine.Utils/DictionaryExtensions.cs(88,34): error IDE0370: Suppression is unnecessary (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0370)

@dotnet/roslyn-ide / @dotnet/roslyn-infrastructure do you know why this diagnostic starts appearing all of a sudden, was there some fix?

I'm also not sure why it doesn't appear in the release/10.0.2xx branch. Maybe it's some .NET 10 vs 11 difference (something with analysis level)...?

@ViktorHofer

Copy link
Copy Markdown
Member

/__w/1/s/.dotnet/sdk/10.0.100/NuGet.Build.Tasks.Pack.targets(222,5): error : The process cannot access the file '/__w/1/s/src/roslyn/artifacts/packages/Release/Shipping/Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator.5.3.0-ci.nupkg' because it is being used by another process. [/__w/1/s/src/roslyn/src/VisualStudio/IntegrationTest/Harness/SourceGenerator/Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator.csproj]

Looks like you have a race in roslyn that you might want to look into. Will probably go away after a retry.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team December 19, 2025 12:39
@ViktorHofer

ViktorHofer commented Dec 19, 2025

Copy link
Copy Markdown
Member

@jjonescz looks like this is from dotnet/roslyn#80794 and this is failing in the SB stage2 leg which uses the just built compiler as the toolset.

Comment thread src/msbuild/src/Framework/ExtendedCriticalBuildMessageEventArgs.cs Outdated
@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team December 19, 2025 12:47
@ViktorHofer

Copy link
Copy Markdown
Member

@jjonescz you are right, my fixes don't work in multi-targeting projects due to different public API annotations in the BCL. Would you mind taking this one over? Feel free to revert my commits.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team December 19, 2025 19:11
@ViktorHofer
ViktorHofer merged commit c4b6dcd into main Dec 19, 2025
15 of 16 checks passed
@ViktorHofer
ViktorHofer deleted the darc-main-32ed21f9-cfdb-4a1a-9319-fb046bfdd2dc branch December 19, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.