Pass the correct item ID when checking the type of an item - #80940
#80940Merged
jasonmalinowski merged 1 commit intoOct 28, 2025
dotnet:maindotnet/roslyn:mainfrom
jasonmalinowski:pass-nested-itemid-for-solution-explorerjasonmalinowski/roslyn:pass-nested-itemid-for-solution-explorerCopy head branch name to clipboard
Merged
Pass the correct item ID when checking the type of an item#80940jasonmalinowski merged 1 commit intodotnet:maindotnet/roslyn:mainfrom jasonmalinowski:pass-nested-itemid-for-solution-explorerjasonmalinowski/roslyn:pass-nested-itemid-for-solution-explorerCopy head branch name to clipboard
jasonmalinowski merged 1 commit into
dotnet:maindotnet/roslyn:mainfrom
jasonmalinowski:pass-nested-itemid-for-solution-explorerjasonmalinowski/roslyn:pass-nested-itemid-for-solution-explorerCopy head branch name to clipboard
Conversation
The HierarchyIdentity has both a regular hierarchy/item ID set and the nested set, and mixing them is bad.
peterwald
approved these changes
Oct 28, 2025
jasonmalinowski
enabled auto-merge (squash)
October 28, 2025 19:58
jasonmalinowski
added a commit
that referenced
this pull request
Oct 28, 2025
The HierarchyIdentity has both a regular hierarchy/item ID set and the nested set, and mixing them is bad.
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HierarchyIdentity has both a regular hierarchy/item ID set and the nested set, and mixing them is bad.