Use built-in inline array types when possible #80557
Open
+354
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of synthesizing inline array types, we want to use the ones from the framework when possible (in .NET 10). Contributes to dotnet#74538.
333fred
commented
Oct 3, 2025
| <NetVSShared>net8.0</NetVSShared> | ||
| <NetRoslynBuildHostNetCoreVersion>net6.0</NetRoslynBuildHostNetCoreVersion> | ||
| <NetRoslynNext>net9.0</NetRoslynNext> | ||
| <NetRoslynNext>net10.0</NetRoslynNext> |
There was a problem hiding this comment.
The only projects using this value are now the Emit3 unit tests, and BuildBoss.
jjonescz
approved these changes
Oct 6, 2025
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
jjonescz
reviewed
Oct 6, 2025
jjonescz
approved these changes
Oct 7, 2025
|
@dotnet/roslyn-compiler for a second review |
AlekseyTs
reviewed
Oct 8, 2025
AlekseyTs
reviewed
Oct 8, 2025
AlekseyTs
reviewed
Oct 8, 2025
|
Done with review pass (commit 4) #Closed |
|
@AlekseyTs for another review pass |
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
| } | ||
|
|
||
| // InlineArray types must be sequential, as we do arithmetic on them. | ||
| var startingOffset = WellKnownType.System_Runtime_CompilerServices_InlineArray2 - 2; |
There was a problem hiding this comment.
This entire method is Conditional(Debug).
AlekseyTs
reviewed
Oct 9, 2025
| return typeSymbol; | ||
| } | ||
|
|
||
| internal static bool TryGetWellKnownType(CSharpCompilation compilation, WellKnownType type, BindingDiagnosticBag diagnostics, Location location, [NotNullWhen(true)] out NamedTypeSymbol? typeSymbol) |
AlekseyTs
reviewed
Oct 9, 2025
| return false; | ||
| } | ||
|
|
||
| ReportUseSite(typeSymbol, diagnostics, location); |
There was a problem hiding this comment.
AlekseyTs
reviewed
Oct 9, 2025
| { | ||
| typeSymbol = compilation.GetWellKnownType(type); | ||
| Debug.Assert((object)typeSymbol != null, "Expect an error type if well-known type isn't found"); | ||
| if (typeSymbol.GetUseSiteInfo().DiagnosticInfo?.Severity == DiagnosticSeverity.Error) |
AlekseyTs
reviewed
Oct 9, 2025
| } | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it would be good to add a test verifying that dependencies are properly tracked. For example, something like the following:
- Create library with a built-in inline array type
- Create a compilation referencing that library and using a scenario that uses the type implicitly
3, Verify that the set of used assembly references includes reference to the library with the inline array type.
|
Done with review pass (commit 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of synthesizing inline array types, we want to use the ones from the framework when possible (in .NET 10). Contributes to #74538.