DAO refactoring#3
Merged
neon-dev merged 10 commits intoJun 16, 2024
beyond-aion:4.8beyond-aion/aion-server:4.8from
Aion-Eternal-Team:4.8-refactory-DAOAion-Eternal-Team/aion-server-beyond:4.8-refactory-DAOCopy head branch name to clipboard
Merged
DAO refactoring#3neon-dev merged 10 commits intobeyond-aion:4.8beyond-aion/aion-server:4.8from Aion-Eternal-Team:4.8-refactory-DAOAion-Eternal-Team/aion-server-beyond:4.8-refactory-DAOCopy head branch name to clipboard
neon-dev merged 10 commits into
beyond-aion:4.8beyond-aion/aion-server:4.8from
Aion-Eternal-Team:4.8-refactory-DAOAion-Eternal-Team/aion-server-beyond:4.8-refactory-DAOCopy head branch name to clipboard
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…tory-DAO # Conflicts: # .editorconfig # game-server/src/com/aionemu/gameserver/GameServer.java # game-server/src/com/aionemu/gameserver/dao/GuideDAO.java # game-server/src/com/aionemu/gameserver/dao/HousesDAO.java # game-server/src/com/aionemu/gameserver/dao/IDFactoryAwareDAO.java # game-server/src/com/aionemu/gameserver/dao/InventoryDAO.java # game-server/src/com/aionemu/gameserver/dao/LegionDAO.java # game-server/src/com/aionemu/gameserver/dao/LegionMemberDAO.java # game-server/src/com/aionemu/gameserver/dao/MailDAO.java # game-server/src/com/aionemu/gameserver/dao/OldNamesDAO.java # game-server/src/com/aionemu/gameserver/dao/PlayerAppearanceDAO.java # game-server/src/com/aionemu/gameserver/dao/PlayerDAO.java # game-server/src/com/aionemu/gameserver/dao/PlayerPetsDAO.java # game-server/src/com/aionemu/gameserver/dao/PlayerRegisteredItemsDAO.java # game-server/src/com/aionemu/gameserver/services/HousingService.java # game-server/src/com/aionemu/gameserver/services/player/PlayerService.java # game-server/src/com/aionemu/gameserver/utils/idfactory/IDFactory.java
# Conflicts: # game-server/src/com/aionemu/gameserver/services/player/PlayerEnterWorldService.java
neon-dev
approved these changes
Jun 16, 2024
Member
|
Thank you for your contribution, highly appreciated! |
rrfarmer
added a commit
to rrfarmer/aion-server
that referenced
this pull request
Jun 18, 2026
…er, HTMLCache) + refined blockers for the remaining 4 PeriodicInstanceManager (beyond-aion#3) + HTMLCache (beyond-aion#4) wired via real-data fixture seeds. The other 4 sit at a real floor: beyond-aion#1 SiegeService.initSieges + beyond-aion#5 PvpMapService need the heavy SPAWNS_DATA + world-map boot (beyond-aion#5 also breaks the empty-world invariant); beyond-aion#2 Housing is DB-required with no Java null guard; #6 PeriodicSaveService is a coordinated DI->singleton re-port. Documented precise blockers + recommended harnesses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the first part to refactor the code removing the DAO.
There are still some things like DB to refactor. /msyql driver etc.
Note: Check very well before merging, it may contain errors. If you find anything to improve (there are many), let me know, I can correct it and add other things.