Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Oct 14, 2023. It is now read-only.

feat: use setModel as rest api already support it#330

Merged
chingor13 merged 1 commit into
googleapis:mastergoogleapis/java-translate:masterfrom
athakor:translate-set-modelathakor/java-translate:translate-set-modelCopy head branch name to clipboard
Oct 30, 2020
Merged

feat: use setModel as rest api already support it#330
chingor13 merged 1 commit into
googleapis:mastergoogleapis/java-translate:masterfrom
athakor:translate-set-modelathakor/java-translate:translate-set-modelCopy head branch name to clipboard

Conversation

@athakor

@athakor athakor commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Fixes #329

@athakor
athakor requested a review from a team October 28, 2020 15:39
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2020
@codecov

codecov Bot commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage     69.90%   69.90%           
  Complexity      220      220           
=========================================
  Files            23       23           
  Lines          1668     1668           
  Branches         46       46           
=========================================
  Hits           1166     1166           
  Misses          457      457           
  Partials         45       45
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/translate/spi/v2/HttpTranslateRpc.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4888010...ea0869e. Read the comment docs.

@product-auto-label product-auto-label Bot added the api: translate Issues related to the googleapis/java-translate API. label Oct 29, 2020
@chingor13
chingor13 merged commit de5b5a8 into googleapis:master Oct 30, 2020
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 30, 2020
@release-please
chore: release 1.95.3 (#275)
5fe037e 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.95.3](https://www.github.com/googleapis/java-translate/compare/v1.95.2...v1.95.3) (2020-10-30)


### Bug Fixes

* increase batch translate timeout to 300 ([#274](https://www.github.com/googleapis/java-translate/issues/274)) ([75736fe](https://www.github.com/googleapis/java-translate/commit/75736fe03ee1298ee153ce9baeb8c81ec82df8a0))
* use setModel as rest api already support it ([#330](https://www.github.com/googleapis/java-translate/issues/330)) ([de5b5a8](https://www.github.com/googleapis/java-translate/commit/de5b5a80fb9e42cf698fd101cffd34474eda0ce9))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#318](https://www.github.com/googleapis/java-translate/issues/318)) ([41293ce](https://www.github.com/googleapis/java-translate/commit/41293ce8a0e6cb410ba0f4a80a8027bc5ee49b3d))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#281](https://www.github.com/googleapis/java-translate/issues/281)) ([e028946](https://www.github.com/googleapis/java-translate/commit/e02894607fea4edaa04486709a0e438a5f5beb20))
* update dependency com.google.cloud:google-cloud-storage to v1.113.2 ([#277](https://www.github.com/googleapis/java-translate/issues/277)) ([ed76cd5](https://www.github.com/googleapis/java-translate/commit/ed76cd53a5a2db0214b1c0986009c7cee7428384))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@munkhuushmgl munkhuushmgl Awaiting requested review from munkhuushmgl
1 more reviewer
@chingor13 chingor13 chingor13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: translate Issues related to the googleapis/java-translate API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use setModel("model") as REST api already support it

2 participants

@athakor @chingor13
Morty Proxy This is a proxified and sanitized view of the page, visit original site.