Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[release/3.0] Update dependencies from dotnet/arcade #35870
Closed
Conversation
…307.4 This change updates the following dependencies - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19157.4 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19157.4 - Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19157.4 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19157.4 - Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19157.4 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19157.4 - Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19157.4 - Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19157.4 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19157.4 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19157.4 - Microsoft.DotNet.SourceRewriter - 1.0.0-beta.19157.4 - Microsoft.DotNet.GenFacades - 1.0.0-beta.19157.4
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
Nope, this actually seems like a langversion issue: For some reason maestro is downgrading the version of the Compilers: Weird, since we don't have a dependency to Roslyn, @jcagme @mmitche is this something to look at on darc? |
|
@tmat Did we take a roslyn update in arcade? |
|
Yeah, this is weird. |
|
Actually, it looks like darc did the right thing initially. it corrected the version in the props file to match details. But then someone manually changed it in release/3.0 811d7e3 |
|
Ahh, interesting. CC @tannergooding @jaredpar. I'll manually update this PR so both versions are |
|
@wtgodbe You also want to ensure that the version and sha match, and probalby set the version details to have a Pinned=true attribute on Dependency |
|
Makes sense to pin this dependency. It will go away soon as we have a PR open in master to just use the version coming from arcade. |
|
Just checked the SHA, it's good. @safern can you link that PR? |
|
That PR is pending arcade picking up the latest compiler version. Last I checked with @jaredpar, that flow wasn't quite automated yet. |
|
@tannergooding @safern @wtgodbe is it still blocked? |
|
I think we should close this PR and have maestro submit a new one. The change to pull in the latest compiler was merged into master and this PR is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/arcade