The Wayback Machine - https://web.archive.org/web/20201212052212/https://github.com/dotnet/corefx/pull/35826
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CoreFX to use Microsoft.Net.Compilers.Toolset and to automatically flow the version from Arcade #35826

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Mar 6, 2019

This updates CoreFX to use the new Microsoft.Net.Compilers.Toolset package which automatically handles the Core vs Full Framework differences.

This also updates CoreFX to automatically flow the consumed toolset version from Arcade, which ensures that we will automatically dogfood new compilers as they become available.

@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Mar 6, 2019

@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Mar 6, 2019

D:\a\1\s.packages\microsoft.net.compilers.toolset\3.1.0-beta1-19127-06\tasks\netcoreapp2.1\Microsoft.CSharp.Core.targets(58,5): error : [D:\a\1\s\src\System.Collections.Concurrent\src\System.Collections.Concurrent.csproj]
D:\a\1\s.packages\microsoft.net.compilers.toolset\3.1.0-beta1-19127-06\tasks\netcoreapp2.1\Microsoft.CSharp.Core.targets(58,5): error : Process is terminating due to StackOverflowException. [D:\a\1\s\src\System.Collections.Concurrent\src\System.Collections.Concurrent.csproj]

CC. @jaredpar

@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Mar 6, 2019

Stack trace is
stacktrace2.txt -- Worth noting it exceeds the number of stack frames VS supports.

@tannergooding
Copy link
Member Author

@tannergooding tannergooding commented Mar 26, 2019

@safern, I've updated this to explicitly use the latest Microsoft.Net.Compilers.Toolset version so that way it can be merged.

Arcade recently (as in about an hour ago) took the same version in, but it looks like there is some trouble with it flowing right now. We can remove our version once Arcade does flow back down to us.

eng/Version.Details.xml Outdated Show resolved Hide resolved
@safern
Copy link
Member

@safern safern commented Mar 27, 2019

error in packaging leg is being taken care of here: #36390 once merged, we will have to rebase this PR.

@safern
Copy link
Member

@safern safern commented Mar 27, 2019

@tannergooding I rebased and push to consume the CI fix.

@safern
safern approved these changes Mar 27, 2019
@ericstj ericstj merged commit 42ff121 into dotnet:master Mar 27, 2019
15 checks passed
15 checks passed
WIP Ready for review
Details
corefx-ci Build #20190326.51 succeeded
Details
corefx-ci (Linux arm64_Release) Linux arm64_Release succeeded
Details
corefx-ci (Linux arm_Release) Linux arm_Release succeeded
Details
corefx-ci (Linux musl_arm64_Release) Linux musl_arm64_Release succeeded
Details
corefx-ci (Linux musl_x64_Debug) Linux musl_x64_Debug succeeded
Details
corefx-ci (Linux x64_Release) Linux x64_Release succeeded
Details
corefx-ci (Packaging All Configurations x64_Debug) Packaging All Configurations x64_Debug succeeded
Details
corefx-ci (Windows NETFX_x86_Release) Windows NETFX_x86_Release succeeded
Details
corefx-ci (Windows UWP_CoreCLR_x64_Debug) Windows UWP_CoreCLR_x64_Debug succeeded
Details
corefx-ci (Windows UWP_NETNative_x86_Release) Windows UWP_NETNative_x86_Release succeeded
Details
corefx-ci (Windows x64_Debug) Windows x64_Debug succeeded
Details
corefx-ci (Windows x86_Release) Windows x86_Release succeeded
Details
corefx-ci (macOS x64_Debug) macOS x64_Debug succeeded
Details
license/cla All CLA requirements met.
Details
@karelz karelz added this to the 3.0 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.