The Wayback Machine - https://web.archive.org/web/20201212051136/https://github.com/dotnet/corefx/pull/36103
Skip to content
Sign up
Sign in Sign up

/ corefx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from dotnet/arcade #36103

Closed
wants to merge 1 commit into from
Closed

[master] Update dependencies from dotnet/arcade #36103

wants to merge 1 commit into from

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 17, 2019 •
edited

This pull request updates the following dependencies

Updates from https://github.com/dotnet/arcade

  • Microsoft.DotNet.ApiCompat - 1.0.0-beta.19162.7
  • Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19162.7
  • Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19162.7
  • Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19162.7
  • Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19162.7
  • Microsoft.DotNet.GenAPI - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19162.7
  • Microsoft.DotNet.SourceRewriter - 1.0.0-beta.19162.7
  • Microsoft.DotNet.GenFacades - 1.0.0-beta.19162.7

Updates from https://github.com/dotnet/arcade

  • Microsoft.DotNet.ApiCompat - 1.0.0-beta.19162.7
  • Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19162.7
  • Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19162.7
  • Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19162.7
  • Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19162.7
  • Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19162.7
  • Microsoft.DotNet.GenAPI - 1.0.0-beta.19162.7
  • Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19162.7
  • Microsoft.DotNet.SourceRewriter - 1.0.0-beta.19162.7
  • Microsoft.DotNet.GenFacades - 1.0.0-beta.19162.7
dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20190…
Loading status checks…
86778aa 
…312.7

This change updates the following dependencies
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19162.7
- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19162.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19162.7
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19162.7
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19162.7
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19162.7
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19162.7
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19162.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19162.7
- Microsoft.DotNet.SourceRewriter - 1.0.0-beta.19162.7
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19162.7
@dotnet-maestro
Copy link
Contributor Author

@dotnet-maestro dotnet-maestro bot commented Mar 17, 2019 •
edited

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux arm_Release), corefx-ci (Linux musl_arm64_Release), corefx-ci (macOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows UWP_NETNative_x86_Release), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux arm64_Release), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
@stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 17, 2019

@mmitche, @safern, I don't know where the problem stems from, but all legs are failing with errors like this:

/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: The "SplitReferences" task failed unexpectedly. [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (Exception from HRESULT: 0x80131621) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: File name: 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Packaging.SplitReferences.Execute() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Targets/Microsoft.NETCore.Targets.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: The "SplitReferences" task failed unexpectedly. [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (Exception from HRESULT: 0x80131621) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018: File name: 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Packaging.SplitReferences.Execute() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(612,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018: The "ApplyPreReleaseSuffix" task failed unexpectedly. [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018: System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (Exception from HRESULT: 0x80131621) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018: File name: 'NuGet.Frameworks, Version=4.9.3.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at System.Signature.GetSignature(Void* pCorSig, Int32 cCorSig, RuntimeFieldHandleInternal fieldHandle, IRuntimeMethodInfo methodHandle, RuntimeType declaringType) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at System.Reflection.RuntimeMethodInfo.FetchNonReturnParameters() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at System.Reflection.RuntimeMethodInfo.GetParameters() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.GetCallbackMethodsForType(Type type, List`1& onSerializing, List`1& onSerialized, List`1& onDeserializing, List`1& onDeserialized, List`1& onError) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveCallbackMethods(JsonContract contract, Type t) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.InitializeContract(JsonContract contract) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateObjectContract(Type objectType) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract(Type objectType) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract(Type type) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Packaging.PackageIndex.Load(String packageIndexFile) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageIndex.cs:line 67 [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Packaging.PackageIndex.Load(IEnumerable`1 packageIndexFiles) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageIndex.cs:line 51 [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Microsoft.DotNet.Build.Tasks.Packaging.ApplyPreReleaseSuffix.Execute() in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/ApplyPreReleaseSuffix.cs:line 67 [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
/Users/vsts/agent/2.148.1/work/1/s/.packages/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.19162.7/build/Packaging.targets(843,5): error MSB4018:  [/Users/vsts/agent/2.148.1/work/1/s/pkg/Microsoft.NETCore.Platforms/Microsoft.NETCore.Platforms.pkgproj]
    0 Warning(s)
    3 Error(s)
@dotnet-maestro
Copy link
Contributor Author

@dotnet-maestro dotnet-maestro bot commented Mar 17, 2019 •
edited

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux arm_Release), corefx-ci (Linux musl_arm64_Release), corefx-ci (macOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows UWP_NETNative_x86_Release), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux arm64_Release), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
@mmitche
Copy link
Member

@mmitche mmitche commented Mar 18, 2019

@JohnTortugo Is this related to the release pipeline work?
@dotnet-maestro
Copy link
Contributor Author

@dotnet-maestro dotnet-maestro bot commented Mar 18, 2019 •
edited

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux arm_Release), corefx-ci (Linux musl_arm64_Release), corefx-ci (macOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows UWP_NETNative_x86_Release), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux arm64_Release), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
@JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Mar 18, 2019

@JohnTortugo Is this related to the release pipeline work?

I don't think it is. Looks more something related to packaging.
@dotnet-maestro
Copy link
Contributor Author

@dotnet-maestro dotnet-maestro bot commented Mar 18, 2019 •
edited

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux arm_Release), corefx-ci (Linux musl_arm64_Release), corefx-ci (macOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Windows UWP_NETNative_x86_Release), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux arm64_Release), corefx-ci (Windows NETFX_x86_Release), corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)
@safern
Copy link
Member

@safern safern commented Mar 18, 2019

@ericstj and I just took a look, it seems what it broke it was this change: dotnet/arcade#2091 because it bumped the NuGet version to a greatest version of what MSBuild depends on. So basically this is exposing an MSBuild bug that doesn't let you use newer versions of the assemblies that they directly depend on.

I guess the right direction is to close until that change in arcade is reverted or we find a workaround to not hit these issues. @ericstj is opening an issue in MSBuild and we'll follow up with the arcade changes.
@safern safern closed this Mar 18, 2019
@safern safern deleted the darc-master-1249668c-f925-4534-8700-4139893c027b branch Mar 18, 2019
@safern
Copy link
Member

@safern safern commented Mar 18, 2019

@tmat for corefx's purposes I think using 4.9.2 would be enough, but I don't know for other repos. Would you mind jumping on this?
@ericstj ericstj mentioned this pull request Mar 18, 2019
Closed
@karelz karelz added this to the 3.0 milestone Mar 18, 2019
@tmat
Copy link
Member

@tmat tmat commented Mar 18, 2019

@safern Well, we need that change to generate correct license metadata to the packages. Which MSBuild version are we talking about? Can we use newer msbuild?
@safern
Copy link
Member

@safern safern commented Mar 18, 2019

@safern Well, we need that change to generate correct license metadata to the packages. Which MSBuild version are we talking about? Can we use newer msbuild?

4.9.2 has the required properties needed to generate the correct license metadata. We're currently using sdk: 2.2.103 which has MSBuild 15.9.2 -- if we bump the SDK to 3.0 we would be forcing people to install that SDK globally for VS to work for their development, which I guess we don't want to enforce now.
@tmat
Copy link
Member

@tmat tmat commented Mar 18, 2019

Ok, if 4.9.2 works then feel free to change the version to 4.9.2.
@wtgodbe wtgodbe mentioned this pull request Mar 18, 2019
Closed
@stephentoub stephentoub mentioned this pull request Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@stephentoub @mmitche @JohnTortugo @safern @tmat @karelz
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.