Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: update grpc x-goog-user-project handling gracefulness - #1983

#1983
Merged
BenWhitehead merged 6 commits into
maingoogleapis/java-storage:mainfrom
quotaProjectId-gracefulnessgoogleapis/java-storage:quotaProjectId-gracefulnessCopy head branch name to clipboard
Apr 20, 2023
Merged

fix: update grpc x-goog-user-project handling gracefulness#1983
BenWhitehead merged 6 commits into
maingoogleapis/java-storage:mainfrom
quotaProjectId-gracefulnessgoogleapis/java-storage:quotaProjectId-gracefulnessCopy head branch name to clipboard

Conversation

@BenWhitehead

Copy link
Copy Markdown
Collaborator

When an instance of credentials that hasRequestMetadata() but can't refresh an IllegalStateException can be thrown. Add new tests to force failure and update handling to be graceful of this.

Related to #1877
b/278179512

@BenWhitehead
BenWhitehead requested a review from a team April 14, 2023 18:26
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Apr 14, 2023
@gcf-owl-bot
gcf-owl-bot Bot requested a review from a team April 14, 2023 18:28
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 14, 2023
@BenWhitehead
BenWhitehead force-pushed the quotaProjectId-gracefulness branch from 3b9b36e to 7f8f45b Compare April 14, 2023 19:10
When an instance of credentials that hasRequestMetadata() but can't refresh an IllegalStateException can be thrown. Add new tests to force failure and update handling to be graceful of this.
@BenWhitehead
BenWhitehead force-pushed the quotaProjectId-gracefulness branch from 7f8f45b to c202362 Compare April 14, 2023 22:24
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@BenWhitehead
BenWhitehead merged commit f274739 into main Apr 20, 2023
@BenWhitehead
BenWhitehead deleted the quotaProjectId-gracefulness branch April 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.