]>
BookStack Code Mirror - bookstack/log
Dan Brown [Sat, 31 Oct 2020 22:11:27 +0000 (22:11 +0000)]
Merge branch 'fixes' of git://github.com/imanghafoori1/BookStack into imanghafoori1-fixes
Dan Brown [Sat, 31 Oct 2020 21:56:48 +0000 (21:56 +0000)]
Merge pull request #2298 from timoschwarzer/composer-install-in-entrypoint
Install composer dependencies in Docker entrypoint
Dan Brown [Sat, 31 Oct 2020 15:19:33 +0000 (15:19 +0000)]
Merge branch 'xss_and_redir_patch' of git://github.com/PercussiveElbow/BookStack into xss_and_redirect
Dan Brown [Sat, 31 Oct 2020 15:01:52 +0000 (15:01 +0000)]
Prevented possible XSS via link attachments
This filters out potentially malicious javascript: or data: uri's coming
through to be attached to attachments.
Added tests to cover.
Thanks to Yassine ABOUKIR (@yassineaboukir on twitter) for reporting this
vulnerability.
PercussiveElbow [Tue, 27 Oct 2020 01:34:51 +0000 (01:34 +0000)]
XSS and redirect fixes with test cases
imanghafoori [Fri, 16 Oct 2020 15:10:44 +0000 (18:40 +0330)]
Adds laravel-microscope package
imanghafoori [Thu, 15 Oct 2020 23:27:36 +0000 (02:57 +0330)]
fixes from laravel-microscope
Dan Brown [Tue, 13 Oct 2020 22:17:23 +0000 (23:17 +0100)]
Merge pull request #2296 from timoschwarzer/esbuild-watch-first-time-fix
Fix build:js:watch not building at first launch in Docker
Dan Brown [Tue, 13 Oct 2020 21:49:55 +0000 (22:49 +0100)]
Updated translator attribution before release v0.30.3
Dan Brown [Tue, 13 Oct 2020 21:44:33 +0000 (22:44 +0100)]
Added alias for vbscript
Dan Brown [Tue, 13 Oct 2020 21:41:09 +0000 (22:41 +0100)]
Merge pull request #2302 from nutsflag/master
Add VBScript Codemirror
Dan Brown [Tue, 13 Oct 2020 21:39:52 +0000 (22:39 +0100)]
Merge pull request #2303 from BookStackApp/l10n_master
New Crowdin updates
Dan Brown [Tue, 13 Oct 2020 21:36:07 +0000 (22:36 +0100)]
Fixed error on drawing edit on markdown editor
Was preventing save of drawings.
For #2313
Dan Brown [Mon, 5 Oct 2020 05:26:38 +0000 (06:26 +0100)]
New translations settings.php (Chinese Simplified)
Dan Brown [Fri, 2 Oct 2020 16:18:27 +0000 (17:18 +0100)]
New translations settings.php (Spanish)
Dan Brown [Fri, 2 Oct 2020 14:55:46 +0000 (15:55 +0100)]
New translations settings.php (Chinese Simplified)
nutsflag [Fri, 2 Oct 2020 13:14:29 +0000 (15:14 +0200)]
Update code.js
nutsflag [Fri, 2 Oct 2020 13:13:31 +0000 (15:13 +0200)]
Update code-editor.blade.php
Timo Schwarzer [Thu, 1 Oct 2020 09:34:56 +0000 (11:34 +0200)]
Install composer dependencies in Docker entrypoint
Timo Schwarzer [Thu, 1 Oct 2020 09:25:22 +0000 (11:25 +0200)]
Fix build:js:watch not building at first launch in Docker
Dan Brown [Wed, 30 Sep 2020 21:32:03 +0000 (22:32 +0100)]
Updated http service to not read 204 response data
Dan Brown [Wed, 30 Sep 2020 21:28:53 +0000 (22:28 +0100)]
Updated esbuild options and version & updated npm deps
Had to change way sortable is imported due to changes, Still
seemed to have functioning multi-select.
Dan Brown [Mon, 28 Sep 2020 21:26:50 +0000 (22:26 +0100)]
Updated page content related links on content id changes
For #2278
Dan Brown [Mon, 28 Sep 2020 20:55:24 +0000 (21:55 +0100)]
Fixed duplicate requests in attachment manager issue
Closes #2286
Dan Brown [Mon, 28 Sep 2020 20:15:23 +0000 (21:15 +0100)]
Merge pull request #2272 from jakubboucek/feature/fix-invalid-canonical-redirect
Fixed canonical redirects on non-root url app instances
Dan Brown [Mon, 28 Sep 2020 19:45:38 +0000 (20:45 +0100)]
Updated draw.io references to diagrams.net
Related to #2044
Jakub Bouček [Tue, 22 Sep 2020 23:22:03 +0000 (01:22 +0200)]
Fixed canonical redirects on non-root url app instances
If BookStack instance is deployed to any non-root path, e.g. http://example.com/wiki/,
requests for http://example.com/wiki/shelves/
was redirected to http://example.com/shelves
instead of http://example.com/wiki/shelves
Synced with: https://github.com/laravel/laravel/blob/master/public/.htaccess
Dan Brown [Sat, 26 Sep 2020 17:24:05 +0000 (18:24 +0100)]
Removed redundant test
Now replaced in recent commit by one that checks actual message gets
displayed on the redirect page.
Redirect page changed to login page.
Dan Brown [Sat, 26 Sep 2020 16:48:02 +0000 (17:48 +0100)]
Updated translators fiel with latest
Dan Brown [Sat, 26 Sep 2020 16:46:32 +0000 (17:46 +0100)]
New Crowdin updates (#2262)
* New translations entities.php (Russian)
* New translations settings.php (Russian)
* New translations entities.php (Chinese Simplified)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Chinese Simplified)
* New translations entities.php (Czech)
* New translations common.php (Czech)
* New translations components.php (Czech)
* New translations settings.php (Czech)
* New translations errors.php (Czech)
* New translations settings.php (Czech)
* New translations settings.php (Czech)
* New translations settings.php (Czech)
* New translations settings.php (German)
* New translations settings.php (German)
* New translations entities.php (German)
* New translations validation.php (Czech)
* New translations entities.php (Spanish, Argentina)
* New translations entities.php (German Informal)
* New translations settings.php (German Informal)
* New translations auth.php (Czech)
Dan Brown [Sat, 26 Sep 2020 16:33:43 +0000 (17:33 +0100)]
Updated codemirror and updated codemirror base styles
Aligns styles with current release, since was causing overflow
with scrollbars.
Fixes #2267
Dan Brown [Sat, 26 Sep 2020 16:00:17 +0000 (17:00 +0100)]
Updated PR code to use isA and updated that function definition
Related to #2227
Dan Brown [Sat, 26 Sep 2020 15:55:05 +0000 (16:55 +0100)]
Merge branch 'renderpages' of git://github.com/mr-vinn/BookStack into mr-vinn-renderpages
Dan Brown [Sat, 26 Sep 2020 15:54:24 +0000 (16:54 +0100)]
Added test for includes on book export
Related to #2227
Dan Brown [Sat, 26 Sep 2020 15:43:06 +0000 (16:43 +0100)]
Fixed issue where SAML login not notifiy on existing user
Added testing to cover
Fixes #2263
Dan Brown [Sat, 26 Sep 2020 15:26:30 +0000 (16:26 +0100)]
Updated settings nav to be more flexible
Uses flexbox layout, flexed to content instead of rigid thirds like
before. Also extracted row into own file
Dan Brown [Sat, 26 Sep 2020 14:40:51 +0000 (15:40 +0100)]
Updated callout links to be correct colors
- Also updated to be underlined instead of bold
Dan Brown [Sat, 26 Sep 2020 14:35:13 +0000 (15:35 +0100)]
Merge branch 'master' of git://github.com/alexmannuk/BookStack into alexmannuk-master
Dan Brown [Sat, 26 Sep 2020 14:25:17 +0000 (15:25 +0100)]
Merge pull request #2270 from gertjankrol/feature/test-migrations-workflow
Add `test-migrations` workflow
Dan Brown [Sat, 26 Sep 2020 14:21:21 +0000 (15:21 +0100)]
Merge pull request #2268 from gertjankrol/master
Fix the `AddActivityIndexes` migration's `down()` method
Dan Brown [Sat, 26 Sep 2020 11:11:53 +0000 (12:11 +0100)]
Merge pull request #2274 from abulgatz/patch-1
Fixed "Ubunto Mono" $mono type misspelling
Dan Brown [Sat, 26 Sep 2020 11:01:01 +0000 (12:01 +0100)]
Fixed markdown iframe loading and content alignment
Fixes #2280
Adam [Wed, 23 Sep 2020 21:19:30 +0000 (16:19 -0500)]
Fix "Ubunto Mono" $mono type misspelling
Gertjan Krol [Tue, 22 Sep 2020 17:53:45 +0000 (19:53 +0200)]
Added the `test-migrations` workflow
Gertjan Krol [Tue, 22 Sep 2020 17:22:27 +0000 (19:22 +0200)]
Fixed the `AddActivityIndexes` migration's `down()` method
Dan Brown [Sun, 20 Sep 2020 09:28:01 +0000 (10:28 +0100)]
Merged latest translation changes
Dan Brown [Sun, 20 Sep 2020 08:15:02 +0000 (09:15 +0100)]
Updated translation contributors
Dan Brown [Sat, 19 Sep 2020 22:09:08 +0000 (23:09 +0100)]
Fixed some wording in example env
Dan Brown [Sat, 19 Sep 2020 15:09:43 +0000 (16:09 +0100)]
Updated example env with helpful info
- Added comments to explain the use of the file.
- Added comments to advise that space/hash containing values would need
to be quoted.
Related to #2258
Dan Brown [Sat, 19 Sep 2020 14:44:18 +0000 (15:44 +0100)]
Merge branch 'jb-l10n-fix-czech' of git://github.com/jakubboucek/BookStack into jakubboucek-jb-l10n-fix-czech
Dan Brown [Sat, 19 Sep 2020 14:36:17 +0000 (15:36 +0100)]
Updated locale lists for Bulgarian
Dan Brown [Sat, 19 Sep 2020 14:22:32 +0000 (15:22 +0100)]
New Crowdin translations (#2077)
* New translations entities.php (Portuguese, Brazilian)
* New translations entities.php (Persian)
* New translations entities.php (Spanish, Argentina)
* New translations entities.php (Thai)
* New translations errors.php (German Informal)
* New translations entities.php (Spanish)
* New translations entities.php (French)
* New translations entities.php (Arabic)
* New translations entities.php (Arabic)
* New translations components.php (Portuguese, Brazilian)
* New translations entities.php (Portuguese, Brazilian)
* New translations auth.php (Italian)
* New translations common.php (Italian)
* New translations components.php (Italian)
* New translations entities.php (Italian)
* New translations settings.php (Italian)
* New translations components.php (Chinese Simplified)
* New translations entities.php (Chinese Simplified)
* New translations settings.php (Spanish)
* New translations components.php (German)
* New translations components.php (Japanese)
* New translations components.php (Dutch)
* New translations components.php (German Informal)
* New translations components.php (Portuguese, Brazilian)
* New translations common.php (Ukrainian)
* New translations components.php (Portuguese)
* New translations common.php (Russian)
* New translations components.php (Russian)
* New translations common.php (Slovak)
* New translations components.php (Slovak)
* New translations common.php (Slovenian)
* New translations components.php (Slovenian)
* New translations common.php (Swedish)
* New translations components.php (Swedish)
* New translations common.php (Turkish)
* New translations components.php (Turkish)
* New translations components.php (Ukrainian)
* New translations components.php (Polish)
* New translations common.php (Chinese Simplified)
* New translations common.php (Chinese Traditional)
* New translations components.php (Chinese Traditional)
* New translations common.php (Vietnamese)
* New translations components.php (Vietnamese)
* New translations common.php (Portuguese, Brazilian)
* New translations common.php (Persian)
* New translations components.php (Persian)
* New translations common.php (Spanish, Argentina)
* New translations components.php (Spanish, Argentina)
* New translations common.php (Thai)
* New translations components.php (Thai)
* New translations common.php (Portuguese)
* New translations common.php (Polish)
* New translations common.php (Italian)
* New translations common.php (Bulgarian)
* New translations components.php (Italian)
* New translations components.php (Chinese Simplified)
* New translations components.php (German)
* New translations components.php (Japanese)
* New translations components.php (Dutch)
* New translations components.php (German Informal)
* New translations common.php (French)
* New translations components.php (French)
* New translations common.php (Spanish)
* New translations components.php (Spanish)
* New translations common.php (Arabic)
* New translations components.php (Arabic)
* New translations components.php (Bulgarian)
* New translations common.php (Dutch)
* New translations common.php (Czech)
* New translations components.php (Czech)
* New translations common.php (Danish)
* New translations components.php (Danish)
* New translations common.php (German)
* New translations common.php (Hebrew)
* New translations components.php (Hebrew)
* New translations common.php (Hungarian)
* New translations components.php (Hungarian)
* New translations common.php (Japanese)
* New translations common.php (Korean)
* New translations components.php (Korean)
* New translations common.php (German Informal)
* New translations components.php (German)
* New translations common.php (German)
* New translations entities.php (German)
* New translations common.php (French)
* New translations components.php (French)
* New translations common.php (Spanish)
* New translations components.php (Spanish)
* New translations components.php (Chinese Simplified)
* New translations common.php (Chinese Simplified)
* New translations common.php (Polish)
* New translations components.php (Polish)
* New translations auth.php (Polish)
* New translations entities.php (Polish)
* New translations errors.php (Polish)
* New translations passwords.php (Polish)
* New translations settings.php (Polish)
* New translations settings.php (Polish)
* New translations common.php (Spanish, Argentina)
* New translations components.php (Spanish, Argentina)
* New translations auth.php (Spanish, Argentina)
* New translations entities.php (Spanish, Argentina)
* New translations passwords.php (Spanish, Argentina)
* New translations settings.php (Spanish, Argentina)
* New translations entities.php (German)
* New translations components.php (German Informal)
* New translations common.php (German Informal)
* New translations entities.php (German Informal)
* New translations settings.php (Italian)
* New translations settings.php (Dutch)
* New translations settings.php (Thai)
* New translations settings.php (Persian)
* New translations settings.php (Portuguese, Brazilian)
* New translations settings.php (Vietnamese)
* New translations settings.php (Chinese Traditional)
* New translations settings.php (Ukrainian)
* New translations settings.php (Turkish)
* New translations settings.php (Swedish)
* New translations settings.php (Slovenian)
* New translations settings.php (Slovak)
* New translations settings.php (Russian)
* New translations settings.php (Portuguese)
* New translations settings.php (Korean)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Japanese)
* New translations settings.php (Hungarian)
* New translations settings.php (Hebrew)
* New translations settings.php (German)
* New translations settings.php (Danish)
* New translations settings.php (Czech)
* New translations settings.php (Bulgarian)
* New translations settings.php (Arabic)
* New translations settings.php (French)
* New translations settings.php (Spanish, Argentina)
* New translations settings.php (Polish)
* New translations settings.php (Spanish)
* New translations settings.php (German Informal)
* New translations settings.php (Spanish)
* New translations settings.php (French)
* New translations components.php (Turkish)
* New translations settings.php (Turkish)
* New translations entities.php (Turkish)
* New translations common.php (Turkish)
* New translations components.php (Portuguese, Brazilian)
* New translations common.php (Portuguese, Brazilian)
* New translations settings.php (Portuguese, Brazilian)
* New translations settings.php (Chinese Simplified)
* New translations activities.php (Chinese Traditional)
* New translations settings.php (Chinese Traditional)
* New translations activities.php (Chinese Traditional)
* New translations auth.php (Chinese Traditional)
* New translations common.php (Chinese Traditional)
* New translations components.php (Chinese Traditional)
* New translations errors.php (Chinese Traditional)
* New translations passwords.php (Chinese Traditional)
* New translations settings.php (German)
* New translations settings.php (German Informal)
* New translations activities.php (Slovak)
* New translations auth.php (Slovak)
* New translations auth.php (Slovak)
* New translations common.php (Slovak)
* New translations components.php (Slovak)
* New translations components.php (Slovak)
* New translations entities.php (Slovak)
* New translations common.php (Slovak)
* New translations entities.php (Slovak)
* New translations passwords.php (Slovak)
* New translations settings.php (Dutch)
* New translations components.php (Dutch)
* New translations entities.php (Dutch)
* New translations passwords.php (Dutch)
* New translations activities.php (Arabic)
* New translations entities.php (French)
* New translations settings.php (Chinese Traditional)
* New translations settings.php (Chinese Traditional)
* New translations auth.php (Chinese Traditional)
* New translations errors.php (Chinese Traditional)
* New translations activities.php (Japanese)
* New translations auth.php (Japanese)
* New translations entities.php (Chinese Traditional)
* New translations validation.php (Chinese Traditional)
* New translations common.php (Russian)
* New translations components.php (Russian)
* New translations entities.php (Russian)
* New translations settings.php (Russian)
* New translations settings.php (Spanish, Argentina)
* New translations settings.php (Polish)
* New translations settings.php (Polish)
* New translations settings.php (Polish)
* New translations entities.php (Russian)
* New translations entities.php (Portuguese)
* New translations entities.php (Thai)
* New translations entities.php (Spanish, Argentina)
* New translations entities.php (Persian)
* New translations entities.php (Portuguese, Brazilian)
* New translations entities.php (Vietnamese)
* New translations entities.php (Chinese Traditional)
* New translations entities.php (Chinese Simplified)
* New translations entities.php (Ukrainian)
* New translations entities.php (Turkish)
* New translations entities.php (Swedish)
* New translations entities.php (Slovenian)
* New translations entities.php (Slovak)
* New translations entities.php (Polish)
* New translations entities.php (French)
* New translations entities.php (Dutch)
* New translations entities.php (Korean)
* New translations entities.php (Japanese)
* New translations entities.php (Italian)
* New translations entities.php (Hungarian)
* New translations entities.php (Hebrew)
* New translations entities.php (German)
* New translations entities.php (Danish)
* New translations entities.php (Czech)
* New translations entities.php (Bulgarian)
* New translations entities.php (Arabic)
* New translations entities.php (Spanish)
* New translations entities.php (German Informal)
* New translations entities.php (French)
* New translations settings.php (Russian)
* New translations settings.php (Portuguese)
* New translations settings.php (Thai)
* New translations settings.php (Spanish, Argentina)
* New translations settings.php (Persian)
* New translations settings.php (Portuguese, Brazilian)
* New translations settings.php (Vietnamese)
* New translations settings.php (Chinese Traditional)
* New translations settings.php (Chinese Simplified)
* New translations settings.php (Ukrainian)
* New translations settings.php (Turkish)
* New translations settings.php (Swedish)
* New translations settings.php (Slovenian)
* New translations settings.php (Slovak)
* New translations settings.php (Polish)
* New translations settings.php (French)
* New translations settings.php (Dutch)
* New translations settings.php (Korean)
* New translations settings.php (Japanese)
* New translations settings.php (Italian)
* New translations settings.php (Hungarian)
* New translations settings.php (Hebrew)
* New translations settings.php (German)
* New translations settings.php (Danish)
* New translations settings.php (Czech)
* New translations settings.php (Bulgarian)
* New translations settings.php (Arabic)
* New translations settings.php (Spanish)
* New translations settings.php (German Informal)
* New translations entities.php (Spanish)
* New translations settings.php (Spanish)
Dan Brown [Sat, 19 Sep 2020 14:13:18 +0000 (15:13 +0100)]
Moved decode and updated page plaintext decode test
Dan Brown [Sat, 19 Sep 2020 13:58:56 +0000 (14:58 +0100)]
Merge branch 'preview-entities' of git://github.com/mr-vinn/BookStack into mr-vinn-preview-entities
Dan Brown [Sat, 19 Sep 2020 13:58:18 +0000 (14:58 +0100)]
Added test to check text gen decodes HTML entities
Dan Brown [Sat, 19 Sep 2020 11:12:48 +0000 (12:12 +0100)]
Updated composer deps
Dan Brown [Sat, 19 Sep 2020 11:06:45 +0000 (12:06 +0100)]
Added audit log interface
- Displays the currently tracked activities in the system.
Related to #2173 and #1167
Dan Brown [Sat, 19 Sep 2020 08:24:58 +0000 (09:24 +0100)]
Split out Maintenance to separate controller
Vinnie Okada [Fri, 18 Sep 2020 12:54:30 +0000 (06:54 -0600)]
Decode HTML entities
Decode HTML entities in page text before saving it to the database.
Dan Brown [Sun, 13 Sep 2020 18:32:45 +0000 (19:32 +0100)]
Added some robustness to page draft saving
- Updated so that a warning is always shown on error, Not just on first
in chain.
- Added last-resort localStorage content saving.
Dan Brown [Sun, 13 Sep 2020 18:12:15 +0000 (19:12 +0100)]
Fixed visible revision delete menu
Dan Brown [Sun, 13 Sep 2020 17:58:05 +0000 (18:58 +0100)]
Added button for inserting attachment link to a page
For #1460
Dan Brown [Sun, 13 Sep 2020 17:29:48 +0000 (18:29 +0100)]
Continued implementation of attachment drag+drop
Cannot get working in chrome reliably due to conflicting handling of
events and drag+drop API. Getting attachment drop working breaks other
parts of TinyMCE.
Implementing current work as should still work for MD editor and within
FireFox.
Related to #1460
Dan Brown [Sun, 13 Sep 2020 15:33:31 +0000 (16:33 +0100)]
Merge branch 'master' into attachment_drag_drop
Vinnie Okada [Fri, 14 Aug 2020 21:13:52 +0000 (15:13 -0600)]
Implement the renderPages parameter
Render page content when getTree() is called with a true $renderPages
argument.
Dan Brown [Sat, 5 Sep 2020 19:37:23 +0000 (20:37 +0100)]
Added punnycode since its reuquired by markdownit
Is a native, although depricated, nodejs module. Have installed manually
since esbuild could not resolve the nodejs module
Dan Brown [Sat, 5 Sep 2020 18:26:47 +0000 (19:26 +0100)]
Updated saml2 slo config so url is used if no repsonse url
Updated config to change empty string to null since the empty string was
hitting an isset check which caused an empty string to be used instead
of the slo url as a backup option.
Closes #2002
Dan Brown [Sat, 5 Sep 2020 16:26:48 +0000 (17:26 +0100)]
Updated flow to ensure /register/confirm route is used where needed
Was accidentally skipped during previous updates. Will now be used on
saml, ldap & standard registration where required.
Uses session to know if the email was just sent and, if so, show the
confirmation route.
Dan Brown [Sat, 5 Sep 2020 15:54:25 +0000 (16:54 +0100)]
Updated npm deps
Dan Brown [Sat, 5 Sep 2020 15:50:20 +0000 (16:50 +0100)]
Migrated from webpack to esbuild
Jakub Bouček [Mon, 31 Aug 2020 18:21:50 +0000 (20:21 +0200)]
Fix English translations
- Fix obvious bug
- Reunite capitalisation
Jakub Bouček [Mon, 31 Aug 2020 18:20:42 +0000 (20:20 +0200)]
Czech translations: Fix broken labels
Jakub Bouček [Mon, 31 Aug 2020 18:20:28 +0000 (20:20 +0200)]
Czech translations: Add new translations to cs, improve existing
Jakub Bouček [Mon, 31 Aug 2020 15:34:46 +0000 (17:34 +0200)]
Fix Czech translations (email -> e-mail)
In Czech language "email" does not means "email" but "enamel paint", correct is "e-mail".
See in Wikipedia:
- https://cs.wikipedia.org/wiki/E-mail
- https://cs.wikipedia.org/wiki/Email_(barva)
alexmannuk [Mon, 24 Aug 2020 19:03:08 +0000 (20:03 +0100)]
Updated callout link formatting
Updated callout links to use font colouring based on type, with bold text to denote link, instead of using the theme link colour per issue #303.
Dan Brown [Tue, 4 Aug 2020 16:54:50 +0000 (17:54 +0100)]
Prevented email confirmation exception throw on registration
Was preventing any other registration actions from taking place such as
LDAP/SAML group sync. Email confirmation should be actioned by
middleware on post-registration redirect.
Added testing to cover.
Tested for LDAP, SAML and normal registration with email confirmation
required to ensure flows work as expected.
Fixes #2082
Dan Brown [Tue, 4 Aug 2020 14:39:07 +0000 (15:39 +0100)]
Fixed non-visible horizontal rules in dark mode
Fixes #2209
Dan Brown [Tue, 4 Aug 2020 14:26:13 +0000 (15:26 +0100)]
Added warning to role screen for important permissions
Warning related to permissions that could allow a person to promote
their own permissions to gain more privileges than expected.
For #2105.
Dan Brown [Tue, 4 Aug 2020 13:55:01 +0000 (14:55 +0100)]
Removed role 'name' field from database
The 'name' field was really redundant and caused confusion in the
codebase, since the 'Display' name is often used and we have a
'system_name' for the admin and public role.
This fixes #2032, Where external auth group matching has confusing
behaviour as matching was done against the display_name, if no
external_auth field is set, but only roles with a match 'name' field
would be considered.
This also fixes and error where the role users migration, on role
delete, would not actually fire due to mis-matching http body keys.
Looks like this has been an issue from the start. Added some testing to
cover. Fixes #2211.
Also converted phpdoc to typehints in many areas of the reviewed code
during the above.
Dan Brown [Tue, 4 Aug 2020 12:02:31 +0000 (13:02 +0100)]
Removed joint_permissions auto_increment id
Removed auto_incrementing id and set a primary key of the [role_id,
entity_type, entity_id, action] instead since this table could recieve a
lot of activity, especially when permission regeneration was automated,
leading to very high auto_increment counts which could max out the
integer limit.
Also updated some RolesTest comment endpoints to align with
recent route changes.
Should fix #2091
Dan Brown [Tue, 28 Jul 2020 17:19:18 +0000 (18:19 +0100)]
Updated some comment elements and standardised more JS
- Updated comment routes to be simpler.
- Updated comments JS to align better with updated component system.
- Documented available global JS functions/services.
- Removed redundant controller method.
- Added window.$events helpers for validation messages and
success/error.
- Updated JS events system to not be class based for simplicity.
- Added window.trans_plural method to handle pluralisation/replacements
where you already have the translation string itself.
Fixes #1836
Dan Brown [Tue, 28 Jul 2020 15:27:16 +0000 (16:27 +0100)]
Updated public-login redirect to check url
Direct links to the login pages for public instances could lead to a
redirect back to an external page upon login.
This adds a check to ensure the URL is a URL expected from the current
bookstack instance, or at least under the same domain.
Fixes #2073
Dan Brown [Tue, 28 Jul 2020 11:59:43 +0000 (12:59 +0100)]
Updated functionality for logging failed access
- Added testing to cover.
- Linked logging into Laravel's monolog logging system and made log
channel configurable.
- Updated env var names to be specific to login access.
- Added extra locations as to where failed logins would be captured.
Related to #1881 and #728
Dan Brown [Tue, 28 Jul 2020 09:46:40 +0000 (10:46 +0100)]
Merge branch 'auth' of git://github.com/benrubson/BookStack into benrubson-auth
Dan Brown [Tue, 28 Jul 2020 09:45:28 +0000 (10:45 +0100)]
Started attachment drag/drop
Currently fighting between sortable and tinymce mechanisms which prevent
this working due to the different events stopping the drop event while
needing the dragover for cursor placement.
Dan Brown [Sun, 26 Jul 2020 15:36:15 +0000 (16:36 +0100)]
Removed default anchor CSS filtering in dark mode
Due to causing content images to be rendered in unexpected ways.
- Also removed CSS filters from other image usage.
- Tweaked header CSS filtering to not be so aggressive.
- Forced WYSIWYG editor to be on its own layer since that would allow
massive larger performance increases in Safari, especially when using
dark mode.
Closes #2045.
Closes #2154.
Dan Brown [Sun, 26 Jul 2020 14:07:47 +0000 (15:07 +0100)]
Updated pagination colors for visibility
Fixes #1839
Dan Brown [Sun, 26 Jul 2020 13:49:05 +0000 (14:49 +0100)]
Removed a few remaining vue references
Dan Brown [Sat, 25 Jul 2020 10:47:12 +0000 (11:47 +0100)]
Fixed some image manager behaviour
fixed:
- Double click not working after tab usage.
- Synced edit form with select button.
Dan Brown [Sat, 25 Jul 2020 10:18:40 +0000 (11:18 +0100)]
Fixed issue where URL params in image names would cause loading failure
Updated file name handling to route through str:slug to be cleaned up
a little.
Added testing to cover.
Fixes #2161
Dan Brown [Sat, 25 Jul 2020 00:09:35 +0000 (01:09 +0100)]
Removed unused tinymce imagetools plugin
Dan Brown [Fri, 24 Jul 2020 23:25:30 +0000 (00:25 +0100)]
Removed vuejs from the project
Dan Brown [Fri, 24 Jul 2020 23:20:58 +0000 (00:20 +0100)]
Converted image-manager to be component/HTML based
Instead of vue based.
Dan Brown [Fri, 24 Jul 2020 22:41:59 +0000 (23:41 +0100)]
Fixed issue where more images than expected could be deleted
When deleting images, images within the same directory, that have
a suffix of the delete image name, would also be deleted.
Added test to cover.
Dan Brown [Sun, 5 Jul 2020 20:23:57 +0000 (21:23 +0100)]
Tweaked dropdown shadows a tad
Dan Brown [Sun, 5 Jul 2020 20:18:17 +0000 (21:18 +0100)]
Converted the page editor from vue to component
Dan Brown [Sat, 4 Jul 2020 16:04:26 +0000 (17:04 +0100)]
Updated attachment tests to align with front-end changes
Dan Brown [Sat, 4 Jul 2020 15:53:02 +0000 (16:53 +0100)]
Finished breakdown of attachment vue into components
Dan Brown [Tue, 30 Jun 2020 21:12:45 +0000 (22:12 +0100)]
Started migration of attachment manager from vue
- Created new dropzone component.
- Added standard component event system using custom DOM events.
- Added tabs component.
- Added ajax-delete-row component.
Dan Brown [Mon, 29 Jun 2020 22:46:08 +0000 (23:46 +0100)]
Removed tests for removed ajax tag route