PHP 8.3 | ReportWidthTest: fix deprecation notices for ReflectionProperty::setValue()#5984
Merged
swissspidy merged 1 commit intoSep 17, 2024
wp-cli:mainwp-cli/wp-cli:mainfrom
jrfnl:feature/php-8.3-fix-reflectionproperty-setvaluejrfnl/wp-cli:feature/php-8.3-fix-reflectionproperty-setvalueCopy head branch name to clipboard
Merged
PHP 8.3 | ReportWidthTest: fix deprecation notices for ReflectionProperty::setValue()#5984swissspidy merged 1 commit intowp-cli:mainwp-cli/wp-cli:mainfrom jrfnl:feature/php-8.3-fix-reflectionproperty-setvaluejrfnl/wp-cli:feature/php-8.3-fix-reflectionproperty-setvalueCopy head branch name to clipboard
swissspidy merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
jrfnl:feature/php-8.3-fix-reflectionproperty-setvaluejrfnl/wp-cli:feature/php-8.3-fix-reflectionproperty-setvalueCopy head branch name to clipboard
Conversation
swissspidy
approved these changes
Sep 17, 2024
…erty::setValue() The `ReflectionProperty::setValue()` method supports three method signatures, two of which are deprecated as of PHP 8.3. This adjusts the call to `ReflectionProperty::setValue()` in various methods in the `UtilsTest` class to pass `null` as the "object" for setting the value of a static property to make the method calls cross-version compatible. Note: these deprecations were visible in the test summary, but the tests - as they currently are - are not set up correctly to fail builds on deprecation notices, which is probably why this went unnoticed. Ref: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue
8217065 to
51fd5dc
Compare
Contributor
Author
|
Rebased without changes after the merge of #5982. This should allow to get a passing build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ReflectionProperty::setValue()method supports three method signatures, two of which are deprecated as of PHP 8.3.This adjusts the call to
ReflectionProperty::setValue()in various methods in theUtilsTestclass to passnullas the "object" for setting the value of a static property to make the method calls cross-version compatible.Note: these deprecations were visible in the test summary, but the tests - as they currently are - are not set up correctly to fail builds on deprecation notices, which is probably why this went unnoticed.
Ref: https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue