PHP 8.4 | Fix implicitly nullable parameters#5982
Merged
swissspidy merged 1 commit intoSep 17, 2024
wp-cli:mainwp-cli/wp-cli:mainfrom
jrfnl:feature/php-8.4-fix-implicitly-nullablejrfnl/wp-cli:feature/php-8.4-fix-implicitly-nullableCopy head branch name to clipboard
Merged
PHP 8.4 | Fix implicitly nullable parameters#5982swissspidy merged 1 commit intowp-cli:mainwp-cli/wp-cli:mainfrom jrfnl:feature/php-8.4-fix-implicitly-nullablejrfnl/wp-cli:feature/php-8.4-fix-implicitly-nullableCopy head branch name to clipboard
swissspidy merged 1 commit into
wp-cli:mainwp-cli/wp-cli:mainfrom
jrfnl:feature/php-8.4-fix-implicitly-nullablejrfnl/wp-cli:feature/php-8.4-fix-implicitly-nullableCopy head branch name to clipboard
Conversation
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a `null` default value, which are not explicitly declared as nullable. As the minimums supported PHP version of this code base is PHP 5.6, adding the nullability operator to the type declaration is not an option at this time. In this case, however, the parameter is found in the declaration of a `private` method, so removing the type declaration in favour of in-function type checking solves the deprecation without breaking BC (as `private`). Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched). Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
thelovekesh
approved these changes
Sep 16, 2024
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a
nulldefault value, which are not explicitly declared as nullable.As the minimums supported PHP version of this code base is PHP 5.6, adding the nullability operator to the type declaration is not an option at this time.
In this case, however, the parameter is found in the declaration of a
privatemethod, so removing the type declaration in favour of in-function type checking solves the deprecation without breaking BC (asprivate).Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched).
Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types