fix(in-memory-actor) emits warning about promise handler#62
Merged
Merged
fix(in-memory-actor) emits warning about promise handler#62
Conversation
weekens
approved these changes
Jun 2, 2022
Contributor
|
Fix released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you run the getting started example with the
node --trace-warningsflag it yields the following error Warning: a promise was created in a handler but was not returned from itthis fixes it. I return
nullinstead of the innerP.resolve()because the function originally had no return, so this doesn't introduce any new behaviour.If it should return a value then I will gladly make the change.