Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Suggestion: drop bluebird and leverage async/await #64

Copy link
Copy link
@rijnhard

Description

@rijnhard
Issue body actions

This is probably the least important issue but figured we can discuss it anyway.

All the current stable versions of node and browsers support promises and bluebird is not a dependency that libraries should ship with if it can be avoided.

the codebase itself could really benefit from cleanup and a switch to native promises and async/await.

I don't see this adding much value other than decreasing the likelihood of silly errors like #62 and general code legibility (promises with callbacks tend to be less legible in most circumstances than the equivalent async/await).

P.S. I am aware that not ALL promise usages should be transferred to async/await, especially for concurrency but most of the functions tend to be step by step inside anyway.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.