Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

(wip) move maximum/minimumOption to UnorderedFoldable - #3132

#3132
Closed
mschuwalow wants to merge 1 commit into
typelevel:mastertypelevel/cats:masterfrom
mschuwalow:feature/maximumoptionmschuwalow/cats:feature/maximumoptionCopy head branch name to clipboard
Closed

(wip) move maximum/minimumOption to UnorderedFoldable#3132
mschuwalow wants to merge 1 commit into
typelevel:mastertypelevel/cats:masterfrom
mschuwalow:feature/maximumoptionmschuwalow/cats:feature/maximumoptionCopy head branch name to clipboard

Conversation

@mschuwalow

@mschuwalow mschuwalow commented Nov 8, 2019

Copy link
Copy Markdown

resolves #2715 and is a followup to #2832

This currently breaks binary compatibility, but I am unsure on how to best fix this. It would be greatly
appreciated if someone could point me into the right direction.

@travisbrown

travisbrown commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

I'm afraid the only way to "fix" this would be to put the maximumOption and minimumOption implementations back in Foldable and to add a dummy: DummyImplicit = DummyImplicit.dummyImplicit argument to the versions in UnorderedFoldable.

It's a terrible workaround and I hate it, but if we care about having these in the right place I think it's the only way. Unless maybe @mpilquist knows of a way to have Simulacrum generate Ops methods for overrides?

(The *ByOption versions are fine as you have them because they're new since 2.0.0.)

@mschuwalow

mschuwalow commented Nov 20, 2019

Copy link
Copy Markdown
Author

I'm afraid the only way to "fix" this would be to put the maximumOption and minimumOption implementations back in Foldable and to add a dummy: DummyImplicit = DummyImplicit.dummyImplicit argument to the versions in UnorderedFoldable.

It's a terrible workaround and I hate it, but if we care about having these in the right place I think it's the only way. Unless maybe @mpilquist knows of a way to have Simulacrum generate Ops methods for overrides?

(The *ByOption versions are fine as you have them because they're new since 2.0.0.)

Would you recommend proceeding with this workaround? In that case I'll update the pr

@jorgeadriano jorgeadriano mentioned this pull request Feb 21, 2020
Open
@larsrh

larsrh commented Feb 6, 2021

Copy link
Copy Markdown
Contributor

This PR is still marked as WIP and contains some conflicts. Please open a new PR if you're interested in pursuing this feature again.

@larsrh larsrh closed this Feb 6, 2021
@jorgeadriano jorgeadriano mentioned this pull request Jun 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minimumOption and maximumOption could be on UnorderedFoldable

3 participants

@mschuwalow @travisbrown @larsrh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.