Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

#resolves 2715 add minimumoption and maximumoption to unorderedfoldable - #2832

#2832
Closed
mschuwalow wants to merge 0 commit into
typelevel:mastertypelevel/cats:masterfrom
mschuwalow:mastermschuwalow/cats:masterCopy head branch name to clipboard
Closed

#resolves 2715 add minimumoption and maximumoption to unorderedfoldable#2832
mschuwalow wants to merge 0 commit into
typelevel:mastertypelevel/cats:masterfrom
mschuwalow:mastermschuwalow/cats:masterCopy head branch name to clipboard

Conversation

@mschuwalow

@mschuwalow mschuwalow commented May 6, 2019

Copy link
Copy Markdown

Thank you for contributing to Cats!

This is a kind reminder to run sbt prePR and commit the changed files, if any, before submitting.

@codecov-io

codecov-io commented May 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2832 into master will decrease coverage by 0.04%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
- Coverage   94.21%   94.16%   -0.05%     
==========================================
  Files         368      368              
  Lines        6944     6959      +15     
  Branches      301      301              
==========================================
+ Hits         6542     6553      +11     
- Misses        402      406       +4
Impacted Files Coverage Δ
core/src/main/scala/cats/UnorderedFoldable.scala 100% <ø> (ø) ⬆️
...src/main/scala/cats/syntax/unorderedFoldable.scala 88.23% <86.66%> (-11.77%) ⬇️
testkit/src/main/scala/cats/tests/Helpers.scala 96% <0%> (-4%) ⬇️
...scala/cats/kernel/instances/function/package.scala 96.96% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287c27e...fef36c8. Read the comment docs.

@kailuowang

kailuowang commented May 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Is this urgent? if not, can we wait a bit so that we can add them directly to the type class once 2.0 is released?

@mschuwalow

mschuwalow commented May 10, 2019

Copy link
Copy Markdown
Author

Is this urgent? if not, can we wait a bit so that we can add them directly to the type class once 2.0 is released?

Sure we can do that. Just comment here once this becomes relevant and I'll update the pr

@travisbrown

travisbrown commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

@mschuwalow Would you want to revisit this now that 2.0 is out and the BinCompat trait isn't necessary?

@mschuwalow

mschuwalow commented Oct 28, 2019

Copy link
Copy Markdown
Author

Sure, I'll try to update the pr this week

@mschuwalow mschuwalow closed this Nov 6, 2019
@LukaJCB

LukaJCB commented Nov 6, 2019

Copy link
Copy Markdown
Member

Hey @mschuwalow, did you close this on purpose? :)
If you no longer want to update the PR do you mind if someone else goes for it?

@mschuwalow mschuwalow mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mschuwalow @codecov-io @kailuowang @travisbrown @LukaJCB
Morty Proxy This is a proxified and sanitized view of the page, visit original site.