Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Dropdown: support .dropdown-item wrapped in <li> tags - #33649

#33649
Merged
XhmikosR merged 2 commits into
twbs:v4-devtwbs/bootstrap:v4-devfrom
cpsievert:tab-li-dropdown-v4cpsievert/bootstrap:tab-li-dropdown-v4Copy head branch name to clipboard
Apr 28, 2021
Merged

Dropdown: support .dropdown-item wrapped in <li> tags#33649
XhmikosR merged 2 commits into
twbs:v4-devtwbs/bootstrap:v4-devfrom
cpsievert:tab-li-dropdown-v4cpsievert/bootstrap:tab-li-dropdown-v4Copy head branch name to clipboard

Conversation

@cpsievert

Copy link
Copy Markdown
Contributor

Backports #33634 into v4

@cpsievert
cpsievert requested review from a team as code owners April 15, 2021 15:23
@cpsievert
cpsievert force-pushed the tab-li-dropdown-v4 branch from a23f117 to 25b7624 Compare April 15, 2021 15:23
@cpsievert
cpsievert changed the base branch from main to v4-dev April 15, 2021 15:24
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
cpsievert added a commit to rstudio/bslib that referenced this pull request Apr 15, 2021
@cpsievert cpsievert mentioned this pull request Apr 15, 2021
2 tasks
@XhmikosR

Copy link
Copy Markdown
Member

Let's wait until the main PR has landed and this one's tests pass.

@XhmikosR
XhmikosR marked this pull request as draft April 16, 2021 05:50
Comment thread js/tests/unit/tab.js Outdated
@cpsievert

This comment has been minimized.

@XhmikosR
XhmikosR marked this pull request as ready for review April 21, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.