Merged
Support .dropdown-item wrapped in <li> tags#306
Conversation
wch
approved these changes
Apr 15, 2021
wch
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. What's the change in sysdata.rda?
Collaborator
Author
|
An internal Google Fonts database (used for lookup inside the real-time themer when fonts are entered) |
Collaborator
|
Opaque changes like that make me think we should reinstate #294. The package size increased by only 26kB in my testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports twbs/bootstrap#33649 into the v4.6.0 release.
This'll allow shiny to use the same HTML structure for tabset dropdowns by requiring
bslib (>= 0.2.4.9003)