[SecurityBundle] add missing xsd definition for OIDC #50453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/SecurityBundle/Resources/config/schema/security-1.0.xsd
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/Resources/config/schema/security-1.0.xsd
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/Resources/config/schema/security-1.0.xsd
Show resolved
Hide resolved
|
Thanks @nicolas-grekas for the feedback, I hope the PR is in a better shape now ! |
nicolas-grekas
previously approved these changes
May 30, 2023
|
Sorry @nicolas-grekas, access token was not usable as-is, I merged defintions to be a little more loose but to make sure every case can be achieved |
src/Symfony/Bundle/SecurityBundle/Resources/config/schema/security-1.0.xsd
Show resolved
Hide resolved
b4b0361 to
02b3508
Compare
src/Symfony/Bundle/SecurityBundle/Resources/config/schema/security-1.0.xsd
Outdated
Show resolved
Hide resolved
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2023
…ler client (vincentchalamon) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [SecurityBundle] Fix configuring OIDC user info token handler client | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#18354 Cf. #50453 (comment) Commits ------- 23c9e17 [SecurityBundle] Fix configuring OIDC user info token handler client
02b3508 to
52280eb
Compare
52280eb to
bff0601
Compare
|
Thank you @aegypius. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #50432
I hope I didn't broke anything this PR is far out of my comfort zone !