[Security] Validate aud and iss claims on OidcTokenHandler
#50432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aud and iss claims on OidcTokenHandler
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Show resolved
Hide resolved
chalasr
reviewed
May 25, 2023
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Show resolved
Hide resolved
aegypius
added a commit
to aegypius/symfony
that referenced
this pull request
May 26, 2023
aegypius
added a commit
to aegypius/symfony
that referenced
this pull request
May 26, 2023
fabpot
added a commit
that referenced
this pull request
May 26, 2023
…g access-token definition (aegypius) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [SecurityBundle] Update security-1.0.xsd to include missing access-token definition | Q | A | ------------- | --- | Branch? |6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Add missing access-token definition in the security XSD schema definition as mentioned in review #50432 (review) Commits ------- abc5e15 [SecurityBundle] Update security-1.0.xsd to include missing access-token definition
aegypius
added a commit
to aegypius/symfony
that referenced
this pull request
May 27, 2023
aegypius
added a commit
to aegypius/symfony
that referenced
this pull request
May 27, 2023
aegypius
added a commit
to aegypius/symfony
that referenced
this pull request
May 30, 2023
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2023
…pius) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [SecurityBundle] add missing xsd definition for OIDC | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Follow-up of #50432 I hope I didn't broke anything this PR is far out of my comfort zone ! Commits ------- bff0601 [SecurityBundle] add missing xsd definition for OIDC
symfony-splitter
pushed a commit
to symfony/security-bundle
that referenced
this pull request
May 30, 2023
…pius) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [SecurityBundle] add missing xsd definition for OIDC | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Follow-up of symfony/symfony#50432 I hope I didn't broke anything this PR is far out of my comfort zone ! Commits ------- bff06016b6 [SecurityBundle] add missing xsd definition for OIDC
|
Rebase unlocked :) |
469a165 to
dcee5a2
Compare
src/Symfony/Bundle/SecurityBundle/Resources/config/security_authenticator_access_token.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Tests/AccessToken/Oidc/OidcTokenHandlerTest.php
Outdated
Show resolved
Hide resolved
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Tests/AccessToken/Oidc/OidcTokenHandlerTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 30, 2023
865cf11 to
9379df7
Compare
|
Thank you @vincentchalamon. |
9379df7 to
90011f5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OIDC Specification, the
audandissclaims MUST be validated by the server.