[Security] OIDC user info token handler client #18354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentchalamon
commented
May 30, 2023
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 30, 2023
…ler client (vincentchalamon) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [SecurityBundle] Fix configuring OIDC user info token handler client | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#18354 Cf. #50453 (comment) Commits ------- 23c9e17 [SecurityBundle] Fix configuring OIDC user info token handler client
|
@nicolas-grekas are you aware of this issue?
|
|
Needs a fix indeed... |
|
OK found it: ->set('security.access_token_handler.oidc.signature', Algorithm::class)
->abstract()
->factory([SignatureAlgorithmFactory::class, 'create'])
->args([
abstract_arg('signature algorithm'),
])
->set('security.access_token_handler.oidc.signature.ES256', ES256::class)
->parent('security.access_token_handler.oidc.signature')
->args(['index_0' => 'ES256'])@nicolas-grekas is there any way to declare an abstract factory, or should I call the factory on each service declaration? |
|
Strange, I would expect this to work. I can have a look a bit later. |
2 tasks
|
Thank you Vincent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.