Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpKernel] Remove BC layer in DebugHandlersListener #41324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

[HttpKernel] Remove BC layer in DebugHandlersListener #41324

merged 1 commit into from
Jul 23, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented May 20, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.0 milestone May 20, 2021
@lyrixx lyrixx force-pushed the sf6-error-handler-dead-code branch from b7db385 to 2f215d9 Compare May 20, 2021 11:09
@lyrixx lyrixx changed the title [HttpKernel] Removed deprecated feature in DebugHandlersListener [HttpKernel] Removed dead code DebugHandlersListener May 20, 2021
@lyrixx lyrixx force-pushed the sf6-error-handler-dead-code branch from 2f215d9 to 8177833 Compare May 20, 2021 11:09
@nicolas-grekas
Copy link
Member

Please rebase to restart tests 🙏

@nicolas-grekas
Copy link
Member

We are missing a BC layer in 5.4 first to deprecate the argument and accept the new signature.
Could you please have a look?

@lyrixx
Copy link
Member Author

lyrixx commented Jul 19, 2021

I was on holiday, I'll have a look on Friday 👍🏼
About the BC: The class is internal now. see #39016 (comment)

@lyrixx lyrixx force-pushed the sf6-error-handler-dead-code branch from 8177833 to 89dd975 Compare July 23, 2021 08:49
@lyrixx lyrixx mentioned this pull request Jul 23, 2021
Merged
@lyrixx lyrixx force-pushed the sf6-error-handler-dead-code branch 2 times, most recently from 56c1f9a to d3f9da0 Compare July 23, 2021 09:11
lyrixx added a commit that referenced this pull request Jul 23, 2021
@lyrixx
minor #42235 [FrameworkBundle] Remove fileLinkFormat property from De…
cbe1f81 
…bugHandlersListener (lyrixx)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Remove fileLinkFormat property from DebugHandlersListener

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

counter part of #41324

Commits
-------

413096a [FrameworkBundle][5.4] Remove fileLinkFormat property from DebugHandlersListener
@lyrixx lyrixx force-pushed the sf6-error-handler-dead-code branch from d3f9da0 to bdd3d28 Compare July 23, 2021 12:48
@lyrixx lyrixx changed the title [HttpKernel] Removed dead code DebugHandlersListener [HttpKernel] Remove BC layer in DebugHandlersListener Jul 23, 2021
@lyrixx
Copy link
Member Author

lyrixx commented Jul 23, 2021

I updated the PR with the new approach

@lyrixx lyrixx merged commit da8e150 into symfony:6.0 Jul 23, 2021
@lyrixx lyrixx deleted the sf6-error-handler-dead-code branch July 23, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @nicolas-grekas @chalasr @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.