Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FrameworkBundle] Remove fileLinkFormat property from DebugHandlersListener #42235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

[FrameworkBundle] Remove fileLinkFormat property from DebugHandlersListener #42235

merged 1 commit into from
Jul 23, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 23, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

counter part of #41324

@carsonbot carsonbot changed the title [FrameworkBundle][5.4] Allow DebugHandlersListener in version 6.0x [FrameworkBundle] [5.4] Allow DebugHandlersListener in version 6.0x Jul 23, 2021
@lyrixx lyrixx mentioned this pull request Jul 23, 2021
Merged
@lyrixx lyrixx force-pushed the sf54-error-handler-dead-code branch 2 times, most recently from 98e50a1 to 752d387 Compare July 23, 2021 09:10
@nicolas-grekas
Copy link
Member

I'm sorry I suggested this approach, but wouldn't it be better to patch DebugHandlersListener instead of the DI ext? To make it accept the service at the new position? Then we bump, no need for FC layer.

@lyrixx lyrixx force-pushed the sf54-error-handler-dead-code branch 3 times, most recently from 974bae9 to 355d689 Compare July 23, 2021 09:41
@lyrixx lyrixx changed the title [FrameworkBundle] [5.4] Allow DebugHandlersListener in version 6.0x [FrameworkBundle][5.4] Remove fileLinkFormat property from DebugHandlersListener Jul 23, 2021
@lyrixx lyrixx force-pushed the sf54-error-handler-dead-code branch 3 times, most recently from 6b78c9b to ebb916b Compare July 23, 2021 10:01
@lyrixx lyrixx force-pushed the sf54-error-handler-dead-code branch from ebb916b to 413096a Compare July 23, 2021 10:05
@carsonbot carsonbot changed the title [FrameworkBundle][5.4] Remove fileLinkFormat property from DebugHandlersListener [FrameworkBundle] [5.4] Remove fileLinkFormat property from DebugHandlersListener Jul 23, 2021
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Jul 23, 2021
@lyrixx lyrixx changed the title [FrameworkBundle] [5.4] Remove fileLinkFormat property from DebugHandlersListener [FrameworkBundle] Remove fileLinkFormat property from DebugHandlersListener Jul 23, 2021
@lyrixx lyrixx merged commit cbe1f81 into symfony:5.4 Jul 23, 2021
@lyrixx lyrixx deleted the sf54-error-handler-dead-code branch June 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.