Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit da8e150

Browse filesBrowse files
committed
minor #41324 [HttpKernel] Remove BC layer in DebugHandlersListener (lyrixx)
This PR was merged into the 6.0 branch. Discussion ---------- [HttpKernel] Remove BC layer in DebugHandlersListener | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- bdd3d28 [HttpKernel] Remove BC layer in DebugHandlersListene
2 parents d6c38ee + bdd3d28 commit da8e150
Copy full SHA for da8e150

File tree

2 files changed

+1
-20
lines changed
Filter options

2 files changed

+1
-20
lines changed

‎src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php
+1-7Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,8 @@ class DebugHandlersListener implements EventSubscriberInterface
4949
* @param bool $scream Enables/disables screaming mode, where even silenced errors are logged
5050
* @param bool $scope Enables/disables scoping mode
5151
*/
52-
public function __construct(callable $exceptionHandler = null, LoggerInterface $logger = null, $levels = \E_ALL, ?int $throwAt = \E_ALL, bool $scream = true, $scope = true, $deprecationLogger = null, $fileLinkFormat = null)
52+
public function __construct(callable $exceptionHandler = null, LoggerInterface $logger = null, $levels = \E_ALL, ?int $throwAt = \E_ALL, bool $scream = true, bool $scope = true, LoggerInterface $deprecationLogger = null)
5353
{
54-
if (!\is_bool($scope)) {
55-
trigger_deprecation('symfony/http-kernel', '5.4', 'Passing a $fileLinkFormat is deprecated.');
56-
$scope = $deprecationLogger;
57-
$deprecationLogger = $fileLinkFormat;
58-
}
59-
6054
$handler = set_exception_handler('var_dump');
6155
$this->earlyHandler = \is_array($handler) ? $handler[0] : null;
6256
restore_exception_handler();

‎src/Symfony/Component/HttpKernel/Tests/EventListener/DebugHandlersListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/EventListener/DebugHandlersListenerTest.php
-13Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use PHPUnit\Framework\TestCase;
1515
use Psr\Log\LoggerInterface;
1616
use Psr\Log\LogLevel;
17-
use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
1817
use Symfony\Component\Console\Application;
1918
use Symfony\Component\Console\Command\Command;
2019
use Symfony\Component\Console\ConsoleEvents;
@@ -35,8 +34,6 @@
3534
*/
3635
class DebugHandlersListenerTest extends TestCase
3736
{
38-
use ExpectDeprecationTrait;
39-
4037
public function testConfigure()
4138
{
4239
$logger = $this->createMock(LoggerInterface::class);
@@ -239,14 +236,4 @@ public function testLevelsAssignedToLoggers(bool $hasLogger, bool $hasDeprecatio
239236
throw $e;
240237
}
241238
}
242-
243-
/**
244-
* @group legacy
245-
*/
246-
public function testLegacyConstructor()
247-
{
248-
$this->expectDeprecation('Since symfony/http-kernel 5.4: Passing a $fileLinkFormat is deprecated.');
249-
250-
new DebugHandlersListener(null, null, \E_ALL, \E_ALL, true, 'filelinkformat', true, $this->createMock(LoggerInterface::class));
251-
}
252239
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.