Fix minor inconsistencies and no-op sprintf detected by static analysis #24649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these changes only affecting 3.3? It looks like some of them apply to older versions (2.7 and 2.8). |
(detected by static analysis)
4c08c58 to
c9ddd68
Compare
|
Created separate PRs for 2.7 and 2.8 |
fabpot
approved these changes
Oct 22, 2017
|
Thank you @TysonAndre. |
fabpot
added a commit
that referenced
this pull request
Oct 22, 2017
…static analysis (TysonAndre) This PR was merged into the 3.3 branch. Discussion ---------- Fix minor inconsistencies and no-op sprintf detected by static analysis and fix required param after optional param | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | Commits ------- c9ddd68 Fix phpdoc inconsistencies, simplify no-op sprintf.
xabbuh
reviewed
Nov 3, 2017
| @@ -108,7 +108,7 @@ public function normalize($object, $format = null, array $context = array()) | ||
| * | ||
| * @return string[] | ||
| */ | ||
| protected function getAttributes($object, $format = null, array $context) | ||
| protected function getAttributes($object, $format, array $context) |
There was a problem hiding this comment.
What is the reason for this change? This is breaking compatibility with classes that extend the AbstractObjectNormalizer.
fabpot
added a commit
that referenced
this pull request
Nov 3, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Serializer] readd default argument value | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24649 (comment) | License | MIT | Doc PR | Commits ------- 740abbe [Serializer] readd default argument value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix required param after optional param