Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0aaab05

Browse filesBrowse files
committed
minor #24649 Fix minor inconsistencies and no-op sprintf detected by static analysis (TysonAndre)
This PR was merged into the 3.3 branch. Discussion ---------- Fix minor inconsistencies and no-op sprintf detected by static analysis and fix required param after optional param | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | Commits ------- c9ddd68 Fix phpdoc inconsistencies, simplify no-op sprintf.
2 parents b93ed8d + c9ddd68 commit 0aaab05
Copy full SHA for 0aaab05

File tree

3 files changed

+3
-3
lines changed
Filter options

3 files changed

+3
-3
lines changed

‎src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public function hasMarkedPlace($subject, $placeName, $name = null)
8585
* Returns marked places.
8686
*
8787
* @param object $subject A subject
88-
* @param string $placesNameOnly If true, returns only places name. If false returns the raw representation
88+
* @param bool $placesNameOnly If true, returns only places name. If false returns the raw representation
8989
* @param string $name A workflow name
9090
*
9191
* @return string[]|int[]

‎src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ private function getControllerError($callable)
219219
}
220220

221221
if (2 !== count($callable)) {
222-
return sprintf('Invalid format for controller, expected array(controller, method) or controller::method.');
222+
return 'Invalid format for controller, expected array(controller, method) or controller::method.';
223223
}
224224

225225
list($controller, $method) = $callable;

‎src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public function normalize($object, $format = null, array $context = array())
108108
*
109109
* @return string[]
110110
*/
111-
protected function getAttributes($object, $format = null, array $context)
111+
protected function getAttributes($object, $format, array $context)
112112
{
113113
$class = get_class($object);
114114
$key = $class.'-'.$context['cache_key'];

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.