symfony · fabpot · Oct 22, 2017 · Oct 21, 2017 · xabbuh · Nov 3, 2017
diff --git a/src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php b/src/Symfony/Bridge/Twig/Extension/WorkflowExtension.php
@@ -85,7 +85,7 @@ public function hasMarkedPlace($subject, $placeName, $name = null)
     * Returns marked places.
     *
     * @param object $subject        A subject
-     * @param string $placesNameOnly If true, returns only places name. If false returns the raw representation
+     * @param bool   $placesNameOnly If true, returns only places name. If false returns the raw representation
     * @param string $name           A workflow name
     *
     * @return string[]|int[]

diff --git a/src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php b/src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php
@@ -219,7 +219,7 @@ private function getControllerError($callable)
        }

        if (2 !== count($callable)) {
-            return sprintf('Invalid format for controller, expected array(controller, method) or controller::method.');
+            return 'Invalid format for controller, expected array(controller, method) or controller::method.';
        }

        list($controller, $method) = $callable;

diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -108,7 +108,7 @@ public function normalize($object, $format = null, array $context = array())
     *
     * @return string[]
     */
-    protected function getAttributes($object, $format = null, array $context)
+    protected function getAttributes($object, $format, array $context)
    {
        $class = get_class($object);
        $key = $class.'-'.$context['cache_key'];
-Original file line number
+Diff line change
@@ -108,7 +108,7 @@ public function normalize($object, $format = null, array $context = array())
          *
          * @return string[]
          */
-        protected function getAttributes($object, $format = null, array $context)
+        protected function getAttributes($object, $format, array $context)
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            xabbuh
  

      

      

      


        Nov 3, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      What is the reason for this change? This is breaking compatibility with classes that extend the AbstractObjectNormalizer.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            chalasr reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
         {
             $class = get_class($object);
             $key = $class.'-'.$context['cache_key'];
-          Expand Down